RELOAD!

[rubberduck-vba/Rubberduck] 8 commits. 1 opened issue. 5 closed issues. 12 issue comments. 1431 additions. 993 deletions.

[Minesweeper] Games Played: 66, Bombs Used: 42, Moves Performed: 8500, New Users: 14

@mansellan that will be the day Mug can finally accept his #IndustryDisruptor crown with pride.

Black background with white font to immediately call out any and all HN of strFooBar or intCount.

@IvenBach no crown, please! besides, at the rate I work on Avalon code panes.........

HAha.

@IvenBach now I wonder if there would be a HN fan to like it like this

lol

Any time I have to draw attention to a range I use Black background + white font for #IWillNotBeIgnored.

that works :)

You have any suggestion on how to address MDoerner's comment on my PR?

I spent far too much time to understand it.

[rubberduck-vba/Rubberduck] bclothier created pull request #5211: Plug the WPF leak... maybe. to merge bclothier/Rubberduck/PlugWPFLeak into rubberduck-vba/Rubberduck/next

@IvenBach it means the concern you're addressing with this property, isn't something that belongs on QualifiedSelection - you want that in higher level code, closer to the UI, like, in some viewmodel class

what Max was referring to, is IValueConverter

...which could be used in the xaml binding, so that you could bind directly to a QualifiedSelection property in the viewmodel

does that even make sense?

            if (!flattenedActual.SequenceEqual(flattenedExpected, comparer))
            {
                if (equals)
                {
                    AssertHandler.OnAssertFailed(message, methodName);
                }
                AssertHandler.OnAssertSucceeded();
            }

            if (!equals)
            {
                AssertHandler.OnAssertFailed(message, methodName);
            }

[rubberduck-vba/Rubberduck] build for commit 6bef5f63 on unknown branch: AppVeyor build succeeded

we reach the first OnAssertSucceeded, but then we continue into the !equal conditional, and thus fail.

yep

OnAssertSucceeded isn't conditional to equals

or am I missing something?

the sequence is in fact not equal

so the assert should succeed

equals is set to false, and flattenedActual.SequenceEqual is false, too, so we enter the first conditional.

what I am thinking is that we should return after the OnAssertSucceeded, not continue into the last conditional

I was going to write an unit test for the AssertHandler but there's no unit tests?

                    if (equals)
                    {
                        AssertHandler.OnAssertFailed(message, methodName);
                    }

                    AssertHandler.OnAssertSucceeded();

grrr

gonna love those markups.

GOT IT!!

not sure. we still need the sequenceequals.

            if (equals && flattenedActual.SequenceEqual(flattenedExpected, comparer))
            {
                AssertHandler.OnAssertSucceeded();
            }

            AssertHandler.OnAssertFailed(message, methodName);

I think that's logically the same. IDK what the idea of the !equals was about; just want to be sure I wasn't missing something.

No, it's not right

I don't understand the logic here... is it missing a return after the OnAssertSucceeded call?

[rubberduck-vba/Rubberduck] bclothier created pull request #5212: Fix the NotSequenceEquals logic to merge bclothier/Rubberduck/FixAsserts into rubberduck-vba/Rubberduck/next

..... FML

this really needs UTs.

I guess nobody wrote it because nobody know how to handle something that's to be used from VBA.

[rubberduck-vba/Rubberduck] bclothier synchronized pull request #5212: Fix the NotSequenceEquals logic

^ now should be better.

[rubberduck-vba/Rubberduck] build for commit 1cb41fc9 on unknown branch: AppVeyor build succeeded

Thanks for the answer Mug. I knew stuffing a new property there wasn't right. Copied what what was already there to get started.

1) Make it work. Done.
2) Make it right. WIP.
3) Make it fast. ToDo.

[rubberduck-vba/Rubberduck] build for commit 121f3d4f on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] bclothier synchronized pull request #5212: Fix the NotSequenceEquals logic

[rubberduck-vba/Rubberduck] bclothier edited pull request #5212: Fix the NotSequenceEquals and EncapuslatePublicInspection logic

[rubberduck-vba/Rubberduck] bclothier edited pull request #5212: Fix the NotSequenceEquals and EncapuslatePublicInspection logic

[rubberduck-vba/Rubberduck] build for commit 84f3096c on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] retailcoder added label stale to issue #3903: Version check shouldn't display the revision & build numbers of the website build

[rubberduck-vba/Rubberduck] retailcoder created comment on issue #3903: Version check shouldn't display the revision & build numbers of the website build

> this is moot now that the website is using the GitHub API for this.

[rubberduck-vba/Rubberduck] retailcoder closed issue #3903: Version check shouldn't display the revision & build numbers of the website build

[rubberduck-vba/Rubberduck] retailcoder assigned retailcoder to issue #4964: VersionCheck enhancements

[rubberduck-vba/Rubberduck] retailcoder merged pull request #5208: suppress warning 1591 about missing xmldoc comment from retailcoder/Rubberduck/suppress1591 into rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] retailcoder pushed commit 2824b409 to next: suppress warning 1591 about missing xmldoc comment

[rubberduck-vba/Rubberduck] web-flow pushed commit 9439c658 to next

[rubberduck-vba/Rubberduck] retailcoder assigned retailcoder to issue #5145: Version check UX enhancements

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.4.1.5061

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.4.1.5061

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot published prerelease Prerelease-v2.4.1.5061

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created tag Prerelease-v2.4.1.5061

[rubberduck-vba/Rubberduck] build for commit 9439c658 on next: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] retailcoder created pull request #5213: Versioncheck tweaks to merge retailcoder/Rubberduck/versioncheck into rubberduck-vba/Rubberduck/next

> I went with an additional, conditionally-enabled checkbox instead of the dropdown suggested in #4964. The prompt will now mention the current/local version, the remote/latest version, whether that's a release or pre-release build, why the message is showing, and how to make it stop showing, while clarifying that nothing will be automatically downloaded or installed. !image The new setting...

is only enabled if the original version check setting is checked: !image The new setting being a bool, it defaults to false without any effort towards making it that way.

May be AWOL for a bit. TLDR = life gave me more fun. Moms in hospital and not looking good. Take care pond.</iven>

@IvenBach sorry to hear - my thoughts are with you.

[rubberduck-vba/Rubberduck] build for commit a7fb0433 on unknown branch: AppVeyor build succeeded

@IvenBach Hopefully your mom pulls through. Take care of family first; duck'll be here.

@IvenBach Hope she'll get well soon.

[rubberduck-vba/Rubberduck] retailcoder commented on Rubberduck.CodeAnalysis/Inspections/Concrete/SuspiciousLetAssignmentInspection.cs of pull request #5167: Suspicious Let assignment inspection

[rubberduck-vba/Rubberduck] bclothier commented on Rubberduck.CodeAnalysis/Inspections/Concrete/SuspiciousLetAssignmentInspection.cs of pull request #5167: Suspicious Let assignment inspection

[rubberduck-vba/Rubberduck] bclothier commented on Rubberduck.CodeAnalysis/Inspections/Concrete/SuspiciousLetAssignmentInspection.cs of pull request #5167: Suspicious Let assignment inspection

@Duga Wrong PR.

hm. It's already merged.

[rubberduck-vba/Rubberduck] bclothier created comment on pull request #5204: inspection xml-doc analyzer

[rubberduck-vba/Rubberduck] glowingrunes created pull request #5214: Added the ClearSearchCommand to the SearchBox ValueContainer. to merge glowingrunes/Rubberduck/5137-TextBoxClearOnEsc into...

rubberduck-vba/Rubberduck/next

[rubberduck-vba/Rubberduck] glowingrunes created comment on issue #5137: Clear SearchBox control by pressing ESC

> Finished! Sorry that took so long. Tried to start work on this issue a few days ago, but couldn't get the solution to build in Visual Studio 2019. Works fine in Visual Studio 17 though. Anyway, this was nice to do - it's been a while since I've touched WPF!

[rubberduck-vba/Rubberduck] build for commit bed9ac58 on unknown branch: AppVeyor build failed

BUILD FAILURE!

[rubberduck-vba/Rubberduck] bclothier created comment on pull request #5214: Added the ClearSearchCommand to the SearchBox ValueContainer.

> Thanks! The build failure seems to be a strange fluke. We will need to give AV a swift kick in the rear to verify it is just a fluke.

Update: was a terminal injury and death was inevitable. I was fortunate enough to be on the best of terms with Mom last time we talked. Life’s about relationships with others. Not things. Thanks for the support all.