12:00 AM
2 hours later…
2:24 AM
[rubberduck-vba/Rubberduck] IvenBach created comment on issue #4987: Parse tree visualizer for Visual Studio
3:01 AM
[rubberduck-vba/Rubberduck] PeterMTaylor created comment on pull request #5146: Inspections for failed default member resolutions
3 hours later…
5:47 AM
[rubberduck-vba/Rubberduck] zspitz edited comment on issue #4987: Parse tree visualizer for Visual Studio
6 hours later…
11:29 AM
11:59 AM
[rubberduck-vba/Rubberduck] MDoerner synchronized pull request #5146: Inspections for failed default member resolutions
2 hours later…
1:47 PM
[rubberduck-vba/Rubberduck] retailcoder closed issue #4997: Object variables reported for scalar properties
[rubberduck-vba/Rubberduck] retailcoder closed issue #4618: (Yet another) False positive for 'Assignment without Set' inspection
[rubberduck-vba/Rubberduck] retailcoder closed issue #4161: Code inspection give incorrect Set warnings for variants and indexed collections
[rubberduck-vba/Rubberduck] retailcoder merged pull request #5146: Inspections for failed default member resolutions from MDoerner/Rubberduck/FailedLetCoercionOnObjectInspection into...
[rubberduck-vba/Rubberduck] MDoerner pushed commit 7415d641 to next: Set up infrastructure to store failed procedure coercions
[rubberduck-vba/Rubberduck] MDoerner pushed commit 5a733e98 to next: Store failed procedure coercions for non-parameterized call statements
Introduce ProcedureRequiredInspection
This inspection reports all places in which an unparameterized procedure call is required but an object variable has been provided.
This inspection reports all places in which an unparameterized procedure call is required but an object variable has been provided.
[rubberduck-vba/Rubberduck] MDoerner pushed commit 82c8b0da to next: Extract separate failed/unpund resolution collections on ModuleState into IFailedResolutionStore
[rubberduck-vba/Rubberduck] MDoerner pushed commit 14f957be to next: Set up infrastructure to store failed indexed default member accesses
Collect failed indexed default member resolutions
This also fixes various small bugs in the reference resolver. Moreover, now we actually check whether the number or arguments provided fits for index expressions.
This also fixes various small bugs in the reference resolver. Moreover, now we actually check whether the number or arguments provided fits for index expressions.
Add DefaultMemberRequiredInspection
This inspection finds all failed indexed default member resolutions. The non-indexed ones are already covered by the ValueRequiredInspection and the ProcedureRequiredInspection.
This inspection finds all failed indexed default member resolutions. The non-indexed ones are already covered by the ValueRequiredInspection and the ProcedureRequiredInspection.
[rubberduck-vba/Rubberduck] MDoerner pushed commit f02dd6a1 to next: Do not Let coerce on Property Let regardless of type
Added error numbers for runtime errors in info for failed default member reolution inspections
Also corrects the info for ObjectVariableNotSet: it is not always error 91, only if the variable is Nothing
Also corrects the info for ObjectVariableNotSet: it is not always error 91, only if the variable is Nothing
Merge pull request #5146 from MDoerner/FailedLetCoercionOnObjectInspection
New Inspections for failed default member resolutions
New Inspections for failed default member resolutions
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.4.1.4938
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.4.1.4938
4 hours later…
1 hour later…
8:22 PM
[rubberduck-vba/Rubberduck] SteveLaycock opened issue #5147: Code Inspection: Missing default member error
> **Rubberduck version information**
The info below can be copy-paste-completed from the first lines of Rubberduck's log or the About box:
Version 2.4.1.4938
OS: Microsoft Windows NT 10.0.18362.0, x64
Host Product: Microsoft Office x64
Host Version: 16.0.12026.20108
Host Executable: WINWORD.EXE
**Description**
Looks like I'm getting a flase defalut member requirement for the function call StringifyArray. Its the line where I've allowed Ruberduck to insert the ignore annotation.
The info below can be copy-paste-completed from the first lines of Rubberduck's log or the About box:
Version 2.4.1.4938
OS: Microsoft Windows NT 10.0.18362.0, x64
Host Product: Microsoft Office x64
Host Version: 16.0.12026.20108
Host Executable: WINWORD.EXE
**Description**
Looks like I'm getting a flase defalut member requirement for the function call StringifyArray. Its the line where I've allowed Ruberduck to insert the ignore annotation.
[rubberduck-vba/Rubberduck] SteveLaycock added label bug to issue #5147: Code Inspection: Missing default member error
8:35 PM
[rubberduck-vba/Rubberduck] MDoerner added label resolver to issue #5147: Code Inspection: Missing default member error
[rubberduck-vba/Rubberduck] MDoerner created comment on issue #5147: Code Inspection: Missing default member error
> Thanks for reporting this.
This is a problem with the resolver. Currently, the resolution of index expressions does not consider the case of a recursive call. Instead, it allways considers references to the function name as references to the variable holding the return value. This has to be changed.
The inspection itself reports the correct issues based on what the resolver provides.
This is a problem with the resolver. Currently, the resolution of index expressions does not consider the case of a recursive call. Instead, it allways considers references to the function name as references to the variable holding the return value. This has to be changed.
The inspection itself reports the correct issues based on what the resolver provides.
9:09 PM
10:08 PM
@M.Doerner does the resolver currently know about recursive calls? #3140 could be implementable if that knowledge was accessible to inspections.. hm, and we could have a hint-level
RecursiveCallInspection
just to flag them as such.
10:46 PM
[rubberduck-vba/Rubberduck] MDoerner created pull request #5148: Fixes around recursive function calls to merge MDoerner/Rubberduck/FixesAroundRecursiveFunctionCalls into rubberduck-vba/Rubberduck/next
> Closes #5147
This PR fixes that both the `IndexDefaultBinding` and the `ProcdureCoercionBinding` did not consider recursive function calls. For these, the expression referring to the function is classified as a variable becasue that is appropriate for the variable holding the return value. So, this situation needs to be special cased.
This PR fixes that both the `IndexDefaultBinding` and the `ProcdureCoercionBinding` did not consider recursive function calls. For these, the expression referring to the function is classified as a variable becasue that is appropriate for the variable holding the return value. So, this situation needs to be special cased.
10:58 PM
11:09 PM
[rubberduck-vba/Rubberduck] retailcoder closed issue #5147: Code Inspection: Missing default member error
[rubberduck-vba/Rubberduck] retailcoder merged pull request #5148: Fixes around recursive function calls from MDoerner/Rubberduck/FixesAroundRecursiveFunctionCalls into rubberduck-vba/Rubberduck/next
[rubberduck-vba/Rubberduck] MDoerner pushed commit 0e37374f to next: Fix second parameter in format string for results of DefaultMemberRequiredInspection
11:20 PM
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.4.1.4940
[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.4.1.4940
« first day (1927 days earlier) ← previous day next day → last day (1253 days later) »
Transcript for
Sep14
Sep '1915
Sep16
VBA Rubberducking
This chat has moved to Discord: discord.gg/MYX9RECenJ