@IvenBach no, context as in ParserRuleContext - the piece of the parse tree that contains the token for the annotation. But I may be completely misleading you with that.... if you have the Declaration, look into what the AnnotationUpdater can do
Public Sub FooBar(ByVal duk As String) is an air code example. The first token would be Public followed by a space for the second and Sub being a third?
Granted I’m assuming a token can be more complex. Right now I’m going for a simplistic example.
I have a chat room bookmark I need to re-read last time you explained this to me.
@IvenBach For what you want to do, you really just need to inject an IAnnotationUpdater and use that. It abstracts away the rewriter handling.
You will also need to inject an IRewritingManager in order to get a CodePaneRewriteSession you can use with the updater and execute when you want to apply the changes.
The quickfixes don't need the manager because they get handed their rewrite session as a method parameter.
It really annoys me how the first reaction when handed a script to run, is to just to blithely run it then say "it didn't work!" when the correct reaction should be to... read the script....
@MathieuGuindon actually, we resolve to a member call against _Global, because the resolver doesn't see that Sheet1 : Worksheet and ThisWorkbook : Workbook. I really need to get back to that draft pull request.
@MathieuGuindon Nope (shouldn't have been). But I realise it was a terrible mcve so apologies. Weirdly trying to write an MCVE I didn't have that problem. I was passing dates into a sub expecting strings. Fell over in the code I am writing for work with that error. MCVE failed with type mismatch or simply passed. Weird. But anyhoos.... thank you for responding.
@SonGokussj4 the inspection is likely ignoring event handlers; the problem has more to do with the fact that RD is only seeing controls through their Control interface, and there's no easy way to fix that for MSForms controls. This is where @IgnoreModule is useful.
If you need to support multiple RDBMS, consider abstracting the data access code behind some ISomethingRepository interface (say, exposing some GetAllTablesInfo method), and implementing that interface with SqlSomethingRepository, OracleSomethingRepository, and/or MySqlSomethingRepository classes, then code against ISomethingRepository and leverage polymorphism to make the code work with any RDBMS, without needing to rewrite all the data access code; to support a new RDBMS, simply implement the interface and use the new class. c.f. "dependency injection" and OOP. — Mathieu Guindon1 min ago
"I would have to hardcode the list of ways to get them for each different DBMS? For example SELECT OWNER, TABLE_NAME FROM all_tables for Oracle" ...I wonder what makes someone think a given meta-query can work across different RDBMS
Most of people would just fantasize of that sort of thing but then the small voice in back of their head reminds that it's just wrong and not worth the hassles that comes after.
e.g. it has all the information oyu need to know where exactly it is.
because Sub1 could be defined in Module1 and Module2, so having just the member name Sub1 is not enough - you need it to be VBAProject.Module1.Sub1 to disambiguate it from VBAProject.Module2.Sub1
@IvenBach Context is the ParserRuleContext - it's a subset of a module's parse tree. QualifiedContext ties that parse tree node to a specific module in a specific project - the ParserRuleContext has no knowledge of that
Should I be using a RewriteSessionBase as the argument to the IRewriteSession rewriteSession argument of the AnnotationUpdater.AddAnnotation( rewriteSession, ...)?
You will also need to inject an IRewritingManager in order to get a CodePaneRewriteSession you can use with the updater and execute when you want to apply the changes.
but, it doesn't really matter what the IRewritingManager implementation does specifically: all you need to worry about is that it's guaranteed to be able to give you the IRewriteSession that you need for AnnotationUpdater.AddAnnotation
So, back in mid-January, I demoed a new feature to the IT lead. They said to submit it for review with the team that handles this stuff. Mid-Feb, it was assigned to someone to follow up with me. Now it's late July, and I just looked it up to see what happened...
I pinged the person who was supposed to follow up with me.
Question for you Mug. I want to supply an IRewritingManager to the ExecuteToggleTestAnnotationCommand. When I look at newing one up it leads very quickly down a rabbit of of newing everything else it's arguments depend on. I'm sure that leads to a dead duck if I follow that path.
I would go with the command if there's no overaching class (e.g. in the case of refactorings, there are ***Refactoring classes that are invoked by commands)
basically with IoC you have a project that defines a bunch of interfaces, each with one or more implementations; IoC is configured to "map" interfaces to concrete types automatically through a naming convention, such that it knows to inject a Foo into a constructor that's telling it it needs an IFoo; and then Foo has a ctor that says "I need an IBar, and IoC knows to give it a Bar, and Bar has a ctor that says "I need an ISomething, and IoC knows to give it a Something, ..
private void ExecuteToggleTestAnnotationCommand(object parameter)
{
var selectedTestMethodViewModel = (TestMethodViewModel)SelectedItem;
var testMethod = selectedTestMethodViewModel.Method;
var annotationUpdater = new AnnotationUpdater();
var rewritingManager = (IRewritingManager)parameter;
var rewriteSession = rewritingManager.CheckOutCodePaneSession();
if (testMethod.IsEnabled)
{
var qualifiedContext = new QualifiedContext(testMethod.Declaration.QualifiedModuleName, testMethod.Declaration.Context);
You knew I had a question I was trying to correctly word.
@MathieuGuindon would you say that if one has to do that, then the abstraction start to look more like lasagna than an actual abstraction? I've suspected that the reason why people find abstractions hard is because they end up looking at the implementations and thus take on a "understand whole world mentality" which would require Atlas-esque strength to hold up?
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/5051?src=pr&el=h1) Report > Merging [#5051](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/5051?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/ece4060b54f69e6101809c042592b5faf4d20792?src=pr&el=desc) will **decrease** coverage by `0.2%`. > The diff coverage is `46.59%`.
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/5051?src=pr&el=h1) Report > Merging [#5051](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/5051?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/ece4060b54f69e6101809c042592b5faf4d20792?src=pr&el=desc) will **decrease** coverage by `0.2%`. > The diff coverage is `46.59%`.
before i go and start doing stuff with updating OpenSSL, im going to update the intel management engine on my comp first
:/
so the IME update didnt fix it. got new ordinal not found error. used the site you gave me to download the compressed binary and just copied the 2 files i needed to the iCLS folder. got yet another ordinal error (this is a different ordinal)
VBA Rubberducking
VBA Rubberducking