Sub UpdateManualUpdates()
Application.ScreenUpdating = False
Dim lookUpSheet As Worksheet, updateSheet As Worksheet
Dim valueToSearch As String
Dim i As Long, t As Long
Set lookUpSheet = Worksheets("Manual price changes")
Set updateSheet = Worksheets("Price Build-up")
Dim lookUp...
Welcome to Code Review! Please take a moment to edit your post to 1) properly format the code: select all and press Ctrl+K to add the 4-space indent that formats it as a code block; 2) make the title summarize the purpose of the code, as stated in the watermark text of the title field; and 3) walk reviewers through your code, present it to readers - "code dump" posts don't tend to do very well on this site, where reviewers easily spend 30, 60, 90 minutes and more crafting an answer: tell us about the data, the context, why and how things are done. Cheers! — Mathieu Guindon1 min ago
Code dumps on CR have always felt like "here crowd, review this!"
I'll spend 5 seconds making my question, and you can spend an hour answering it
IDK - I think about the fact that it's very common to bring in 100s of development tools just to work with JS, and if you're using something like TypeScript, you're now quite far away from just vanilla JS. You then have to understand stuff like module pattern among others to effectively debug and troubleshoot JavaScript written by those tall stack of tools
It never really stays "just JS" for very long
And from what I've seen, a common response to a malfunction is just to swap out one JavaScript library for another because they have no idea why it's malfunctioning.
yea ... but is that class still on Javascript then?
or on "the web development toolstack and whatever the heck it is on right now"
the problem with JS is that it's fucking garbage for basically everything that it's used for nowadays and it's fiendishly difficult to abstract the quirks of the language
JS is the new PHP, and I still don't understand why people haven't started vocally hating on it in the "mainstream"
Internal contacts seem to be hard to come by, but I've found a name and fired off an email to find out what, exactly, they're rolling out to us.
I'm not opposed to learning me some JS (and descending into the above described levels of hell), but I'd like to know that's where I'm going before my existing code just stops working and everything is on fire
"everything is on fire" kinda the very definition of hell, isn't it?
@Vogel612 Good point. Toolchain isn't really language. However, I would not be surprised that compared to other languages, JS needs much more tools just to "work".
Now I get to document & justify all the VBA I've written to be allowed to have the desktop versions so I can continue to support them.
I'm most certain that my management will back me, I just have no idea if they'll try to absorb it into "IT" instead of leaving it with me, or get mad because I've made a "data warehouse" instead of using our official "EDW" (Electronic DW).
@FreeMan 365 desktop is just a Win32 desktop install of the latest & greatest; VBA isn't affected, but the Excel object model may have members (and features) that don't [yet] exist in the "normal" 3-year releases (e.g. 2016, 2019, etc.)
@FreeMan if you have any VBA code that needs to manipulate more than just the active workbook, you have a rock-solid undefeatable reason to have a desktop install
Here is a set of classes that are used to build where clause for SQL Server and Oracle for different field types e.g. text, numeric and date.
public interface IConditionBuilder
{
bool CanHandle(FilterAction filterAction);
string BuildCondition(SearchCondition filterCondition);
}
public...
I deal with that all the time w/ T-SQL. CAST(lame/dumb AS money) doesn't work, so it has to be CAST(lame AS money)/CAST(dumb AS money). Excessive but it ensures there's no surprises
> For compatibility reasons, the Places Bar is hidden if Flags is set to OFN_ENABLEHOOK and lStructSize is OPENFILENAME_SIZE_VERSION_400.
for those reserved fields, I bet if you dug up a older documentation of the same structure, it'll tell you what they do but would have worked only in older versions of Windows.
In SSIS, I presumed that column mapping was done by column name not column order.
However, it seems that it's done by column order, especially if the file name in the flat file connection manager is parameterized since I cannot see columns once that's happened. is that correct?
FWIW, I had to do something similar (creating a dynamic search thing). Ended up passing the parameters as a XML document, pushing it into a temporary table, which is then joined to sys.columns to verify the parameter name, building dynamic SQL from the temporary table, and using sys.sp_executesql with parameters. That was lot of layers just to avoid concentation directly with user's input. #FunTimes
Even so, I still wonder in back of my head that I've leaked a sql injection attack.
Fortunately, it was for a LAN use, so the concern is less pressing. I'd be sweating profusely had it been a web application.
I don't think it can be changed - read up on the Sunk Cost Fallacy - string-concatenating WHERE clauses is a plague that needs to be eradicated with all the firepower you can throw at it. It will cost more in the long run to keep doing that, than rewriting everything to implement data access code properly, and that's been proven many times over - just ask any company victim of a data breach. String-concatenating WHERE clauses is a very serious security issue. — Mathieu Guindon14 mins ago
You could always repsond: "I guess there's nothing to be done now that your tables have been deleted. This post might have helped before that occurred."
Probably comes off as too passive-aggressive though.
> See, I like Irish whiskey, and code like this makes me want to order a double. What happens when context.Text is Elizabeth O'Connor? Or Patrick O'Neil?
at least they can now run to their manager and say "some random stranger on the Internet is saying there's a massive security issue and we should burn this code with fire"
and then hear "pfft. we've never been hacked before. carry on."
Sub UpdateManualUpdates()
Application.ScreenUpdating = False
Dim lookUpSheet As Worksheet, updateSheet As Worksheet
Dim valueToSearch As String
Dim i As Long, t As Long
Set lookUpSheet = Worksheets("Manual price changes")
Set updateSheet = Worksheets("Price Build-up")
Dim lookUp...
Here is a set of classes that are used to build where clause for SQL Server and Oracle for different field types e.g. text, numeric and date.
public interface IConditionBuilder
{
bool CanHandle(FilterAction filterAction);
string BuildCondition(SearchCondition filterCondition);
}
public...
VBA Rubberducking
VBA Rubberducking