1 hour later…
2:01 AM
2:46 AM
3:01 AM
3:07 AM
2 hours later…
10 hours later…
3:19 PM
[rubberduck-vba/Rubberduck] bclothier synchronized pull request #3836: Gather metadata required for per-user install for Rubberduck
[rubberduck-vba/Rubberduck] bclothier commented on pull request #3836: Gather metadata required for per-user install for Rubberduck
> The latest commits now will build a new installer, with all the parameterization taken in. However, the installer isn't fully functional and running it will cause the VBA to not load. More troubleshooting is needed.
Note that the installer script has been revised a... lot in order to allow for better parameterization and minimizing the code required. I have not cleaned up the code that should be no longer used (e.g. the one for performing the `regasm.exe` - those are no longer called any m
Note that the installer script has been revised a... lot in order to allow for better parameterization and minimizing the code required. I have not cleaned up the code that should be no longer used (e.g. the one for performing the `regasm.exe` - those are no longer called any m
4:25 PM
[rubberduck-vba/Rubberduck] bclothier synchronized pull request #3836: Gather metadata required for per-user install for Rubberduck
4:44 PM
[rubberduck-vba/Rubberduck] bclothier synchronized pull request #3836: Gather metadata required for per-user install for Rubberduck
5:02 PM
5:22 PM
5:35 PM
1 hour later…
6:45 PM
2 hours later…
9:34 PM
[rubberduck-vba/Rubberduck] rkapka created pull request #3845: Fixed inspections and quick fixes registration in Castle Windsor to merge rkapka/Rubberduck/rkapka-ioc into rubberduck-vba/Rubberduck/next
> Apparently some PR broke the IoC registration for inspections and quick fixes. Only
ParseTreeInspections
were registered correctly. Other inspections and all quick fixes were not registered at all or registered having service type of Object
. This PR's purpose is to restore the functionality.
[rubberduck-vba/Rubberduck] rkapka commented on pull request #3845: Fixed inspections and quick fixes registration in Castle Windsor
> I'm not familiar with CW, so this fix might not be the best approach. I don't know why
Base
and Self
services were not working.
[rubberduck-vba/Rubberduck] rkapka review_requested pull request #3845: Fixed inspections and quick fixes registration in Castle Windsor
[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) commented on pull request #3845: Fixed inspections and quick fixes registration in Castle Windsor
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/3845?src=pr&el=h1) Report
> Merging [#3845](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/3845?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/443a039b294800b97b6061747ebb98b61cc1a160?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100%`.
```diff
@@ Coverage Diff @@
## next #3845 +/- ##
===========================
> Merging [#3845](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/3845?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/443a039b294800b97b6061747ebb98b61cc1a160?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `100%`.
```diff
@@ Coverage Diff @@
## next #3845 +/- ##
===========================
9:50 PM
[rubberduck-vba/Rubberduck] retailcoder merged pull request #3845: Fixed inspections and quick fixes registration in Castle Windsor from rkapka/Rubberduck/rkapka-ioc into rubberduck-vba/Rubberduck/next
[rubberduck-vba/Rubberduck] rkapka pushed commit b5a7c477 to next: Fixed inspections and quick fixes registration in Castle Windsor
10:16 PM
10:52 PM
[rubberduck-vba/Rubberduck] MDoerner commented on Rubberduck.Main/Root/RubberduckIoCInstaller.cs of pull request #3845: Fixed inspections and quick fixes registration in Castle Windsor
[rubberduck-vba/Rubberduck] MDoerner commented on Rubberduck.Main/Root/RubberduckIoCInstaller.cs of pull request #3845: Fixed inspections and quick fixes registration in Castle Windsor
[rubberduck-vba/Rubberduck] MDoerner commented on pull request #3845: Fixed inspections and quick fixes registration in Castle Windsor
> I just looked further in the CW documentation. There was no link in the part about registration by convention but in the part about registering component-by-component.
[Conditional component registration](https://github.com/castleproject/Windsor/blob/master/docs/conditional-component-registration.md)
After reading this, I think we should go back to `BasedOn` combined with `If` or `Unless` to deal with the experimental types.
[Conditional component registration](https://github.com/castleproject/Windsor/blob/master/docs/conditional-component-registration.md)
After reading this, I think we should go back to `BasedOn` combined with `If` or `Unless` to deal with the experimental types.
I don't think anyone can compare to Ansel Adams even today, but I think a significant part of the power of his work is the medium.
Most of his pictures wouldn't be portrayed so powerfully if they didn't take advantage of the starkness of black & white medium he used.
[rubberduck-vba/Rubberduck] Hosch250 merged pull request #3840: Enforce the non-default default values from bclothier/Rubberduck/FixSettingDefault into rubberduck-vba/Rubberduck/next
[rubberduck-vba/Rubberduck] bclothier pushed commit 4810e3fc to next: Enforce the non-default default values
[rubberduck-vba/Rubberduck] bclothier pushed commit 352e72ac to next: Merge branch 'next' of github.com/rubberduck-vba/Rubberduck into FixSettingDefault
[rubberduck-vba/Rubberduck] Hosch250 commented on pull request #3825: Fix for the Remove Parameter Refactoring
[rubberduck-vba/Rubberduck] Hosch250 merged pull request #3825: Fix for the Remove Parameter Refactoring from MDoerner/Rubberduck/FixForRemoveParameter into rubberduck-vba/Rubberduck/next
[rubberduck-vba/Rubberduck] MDoerner pushed commit 29bb1612 to next: Removed useless COM accesses from remove parameter refactoring.
[rubberduck-vba/Rubberduck] MDoerner pushed commit f50d522c to next: Added failing tests for removing optional parameters supplied as missing parameters on call sites.
[rubberduck-vba/Rubberduck] MDoerner pushed commit 004efb4d to next: Added failing test for remove parameter removing the argument from call sites in other components.
[rubberduck-vba/Rubberduck] MDoerner pushed commit 1e10cd0c to next: Fixed rewriting callers in other components in the remove parameter refactoring.
[rubberduck-vba/Rubberduck] MDoerner pushed commit b20b017c to next: Removed projects provider from remove parameter refactoring since it is no longer needed.
[rubberduck-vba/Rubberduck] MDoerner pushed commit 6c90dc4f to next: Corrections to expected values in failing remove parameter tests for missing arguments.
[rubberduck-vba/Rubberduck] MDoerner pushed commit e8c2937c to next: Fixed removal of missing arguments for remove parameter refactoring.
[rubberduck-vba/Rubberduck] MDoerner pushed commit 58a5da93 to next: Merge branch 'next' into FixForRemoveParameter
[rubberduck-vba/Rubberduck] MDoerner pushed commit 57ebbca2 to next: Merge branch 'next' into FixForRemoveParameter
Merge pull request #3825 from MDoerner/FixForRemoveParameter
Fix for the Remove Parameter Refactoring
Fix for the Remove Parameter Refactoring
[rubberduck-vba/Rubberduck] bclothier synchronized pull request #3836: Gather metadata required for per-user install for Rubberduck
[rubberduck-vba/Rubberduck] [codecov[bot]](github.com/apps/codecov) commented on pull request #3836: Gather metadata required for per-user install for Rubberduck
> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/3836?src=pr&el=h1) Report
> Merging [#3836](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/3836?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/443a039b294800b97b6061747ebb98b61cc1a160?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `89.47%`.
```diff
@@ Coverage Diff @@
## next #3836 +/- ##
=======================
> Merging [#3836](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/3836?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/443a039b294800b97b6061747ebb98b61cc1a160?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `89.47%`.
```diff
@@ Coverage Diff @@
## next #3836 +/- ##
=======================
11:38 PM
Moderator elections coming up on Code Review Stack Exchange. Thank you for your many years of service, 200_success! https://twitter.com/StackCodeReview/status/975148821931012098
Tweeted by rubberduckvba on March 17, 2018 at 11:32 PM
Not sure if this is sad, or genius... https://twitter.com/kylebshr/status/973965922670018560
Tweeted by rubberduckvba on March 17, 2018 at 11:38 PM
[rubberduck-vba/Rubberduck] retailcoder added label PR-Status: Conflicting to pull request #3835: Freeze column header for vertical scrolling.
[rubberduck-vba/Rubberduck] retailcoder merged pull request #3823: Unify some duplicated codes and make them testable/mockable from bclothier/Rubberduck/UnifyVbeFunctions into rubberduck-vba/Rubberduck/next
[rubberduck-vba/Rubberduck] bclothier pushed commit 489b073c to next: Fix the check on the UiDispatcher; it does not need the CheckContext.
[rubberduck-vba/Rubberduck] bclothier pushed commit 9ef93be3 to next: Make ComMessagePumper take IVBERuntime as an injected dependency instead of newing it up.
[rubberduck-vba/Rubberduck] bclothier pushed commit af33e828 to next: Correct the logic for checking the thread in the pumper.
[rubberduck-vba/Rubberduck] bclothier pushed commit fcd3dca0 to next: Remove unused using declaration
Merge branch 'next' of https://github.com/rubberduck-vba/Rubberduck into UnifyVbeFunctions
# Conflicts:
# RetailCoder.VBE/VBERuntime/IVBESettings.cs
# RetailCoder.VBE/VBERuntime/RegistryWrapper.cs
# RetailCoder.VBE/VBERuntime/VBESettings.cs
# Rubberduck.Core/Rubberduck.Core.csproj
# Rubberduck.Core/UI/Settings/SettingsForm.cs
# Rubberduck.Core/VBERuntime/IVBESettings.cs
# Rubberduck.Core/VBERuntime/RegistryWrapper.cs
# Rubberduck.Core/VBERuntime/VBESettings.cs
# Rubberduck.Main/Root/Rubberduc
# Conflicts:
# RetailCoder.VBE/VBERuntime/IVBESettings.cs
# RetailCoder.VBE/VBERuntime/RegistryWrapper.cs
# RetailCoder.VBE/VBERuntime/VBESettings.cs
# Rubberduck.Core/Rubberduck.Core.csproj
# Rubberduck.Core/UI/Settings/SettingsForm.cs
# Rubberduck.Core/VBERuntime/IVBESettings.cs
# Rubberduck.Core/VBERuntime/RegistryWrapper.cs
# Rubberduck.Core/VBERuntime/VBESettings.cs
# Rubberduck.Main/Root/Rubberduc
[rubberduck-vba/Rubberduck] bclothier pushed commit 606f8288 to next: Address feedbacks and restore some missing code from merge.
[rubberduck-vba/Rubberduck] bclothier pushed commit 195684d7 to next: Make VBEEvents mockable, thanks to Mug
[rubberduck-vba/Rubberduck] bclothier pushed commit 1a5e59f1 to next: Make the guard clauses in RPS explicit, add ignore attribute. Add explanatory comment to highlight the static methods being used for the VBEEvents.
« first day (1380 days earlier) ← previous day next day → last day (1800 days later) »
Transcript for
Mar16
Mar '1817
Mar18
VBA Rubberducking
This chat has moved to Discord: discord.gg/MYX9RECenJ