Hmm. Interesting. This throws an inspection from the R#....
switch (currentContext)
{
case VBAParser.FunctionStmtContext stmt:
stmtContext = stmt;
break;
case VBAParser.SubStmtContext stmt:
stmtContext = stmt;
break;
case VBAParser.PropertyGetStmtContext stmt:
stmtContext = stmt;
break;
case VBAParser.PropertyLetStmtContext stmt:
stmtContext = stmt;
break;
case VBAParser.PropertySetStmtContext stmt:
sez the loop variable isn't changed in the loop. Apparently not smort enough to see that I'm climbing the tree with the currentContext = currentContext.Parent
@Hosch250 public int SomeNumber { get { return _fooNumber; } } can be replaced with public int SomeNumber => _fooNumber; because there is no backing field that's generated.
It's only grabbing the number and that's why it can be replaced with lambda syntax.
> A document module like `ThisWorkbook` has a hidden/implied WithEvents `Workbook` object named `Workbook` (although it is not addressable as `Workbook`, but rather as `Me`), against which, typically, all of the workbook events are wired up with a `Workbook_` prefix.
Likewise, a document module like `Sheet1` has a hidden/implied WithEvents `Worksheet` object named `Worksheet` (although it is not addressable as `Worksheet`, but rather as `Me`), against which the events of the worksheet are wir
_ is basically when you don't care about the output. So therefore, if you have no code that later needs it, it's usually safe to change to _ so you can cut on the variable declarations
Rubberduck.Parsing.VBA has a couple methods constructors that are prompting for protected constructors. This falls out because the class itself is public abstract class ... and as such can't directly be instantiated but needs to be derived from.
Hopefully someone has some kind of solution for this. I need to make a class that maps an entire sub-directory (archived reports) and I need the filenames so that I can match them against a pattern. I got all of that working just fine, but it takes 43 seconds to load the filenames (a retrieval for a single report otherwise takes about 48 seconds, so this would nearly double the time cost). The Scripting.File 'File.Name' accessor seems to be the issue. Any clue why? Or any workaround?
because the way Windows is, the more files there are in a given folder, the more expensive it becomes to enumerate the files - it's not a linear scale. If that is the case, you should consider dividing into further subfolders, perhaps by years & month for instance.
If the files are kept on a remote network drive, then you might want to consider using Windows indexing service and execute SQL query to get back file names.
@this I dont have control over the directory, otherwise I would just keep them organized and wouldnt need a solution like this. The files are in a network drive, but I dont know if they are remote or not. Any examples for the indexing service I can test?
I've recently learnt about the Model-View-Presenter architectural pattern and I wanted to give it a go with a simple VBA project.
The aim is to retrieve a person's name from a UserForm.
The userform looks like this:
A user should select a team, which updates the name field > Select a name b...
If you load up the cmd or ps, then do a dir/ls, how long does it takes to enumerate it all? is it equally slow to bring up a single file name somewhere in the middle of the name in the cmd/ps?
@FreeMan and how do you intend to defend the copyright of something that's no longer maintained, all contributors are long ago bones'n'dust? :)
@BrandonBarney Is is possible for you to build your own index? (comes in late to the discussion, has no real idea of what's going on...) Maybe something that you can refresh in the background of your app and keep stored in a SQL server somewhere?
I want to list every file and directory contained in a directory and subdirectories of that directory. If I chose C:\ as the directory, the program would get every the name of every file and folder on the hard drive that it had access to.
A list might look like
fd\1.txt
fd\2.txt
fd\a\
fd\b\
fd...
anyone have any idea why the VBE opens all code windows each time you launch it? I had 4 modules open on Tuesday (when I was last working), with them arranged all nice & neat like I wanted 'em, and now, everything's open with windows scattered everywhere! (Usually, I work full screen and it doesn't matter, but on occasion I want them windowed). haz a sad
@FreeMan, FWIW, I just close them all, then compile and save. I believe when you save VBA project, it remembers all windows setting but it's quirky. If it's compiled, saving it again doesn't update it or something.
Higher barrier to entry != better code
Correlation != causation, I am sure you all know that.
FWIW VBA has solved a ton of problems, and automated reports that otherwise took us hours or days. We are still finding the potential of VBA, so I would have a hard time convincing them "I need C# and 6 months of practice"
@Hosch250 Its only somewhat debatable. Many data scientists are pushing Python, even though R led the pack for quite a bit. For me, I won the argument by showing what I could do quickly and efficiently in Python, that he couldnt manage in R.
I am at a dead end here. dir "\\some\file\path" /s /b *.xlsx should list all excel files in the directory, and it does, but then starts mapping my local drive as well.
@Hosch250 I am not sure what you mean. I enjoy learning Python plenty. He's the one who doesn't, but he is also a non-programmer.
And Python can certainly still be self-taught, but some of the elements are harder for someone new to the language to understand.
Not to mention RStudio makes it stupid simple to see what is happening with your variables.
@this interesting. thx for the feedback. I've just generally found the VBE to be pretty quirky. Maybe with the coming RD editor environment, RD will save currently open modules & window positions. hint hint
Goes to show you how much I know. :) I know it's technically client-client, but I imagined there'd be additional steps to ensure that this repository is designated as the master of all others' repositories.
@this Thanks for pointing me in the right direction. This ultimately ended up doing the trick:
Function GetFileList(ByVal FolderLocation As String)
Dim WindowsShell As WshShell
Set WindowsShell = New WshShell
Dim Command As String
Command = "cmd /c Dir """ & FolderLocation & """ /s /b /a-d"
GetFileList = Filter(Split(WindowsShell.Exec(Command).StdOut.ReadAll, vbCrLf), ".")
End Function
@Hosch250 that might be a good demo of why they should be using git. They wouldn't have to muck with a db - it's obvious nobody's administrating it since if it were, they'd have gotten an alert if db is getting too fat for the server.
Yeah, I saw 4 from Commit Strip, @Hosch250. I almost dismissed them, thinking they were from SU or SO, but realized they were very short, nothing like question text and did the hover-over.
That would likely decrease performance instead of boosting it.
For some context, I have a class that loads an entire sheet into an array, and then filters and outputs it. It runs just fine on ~20,000 records (about 20 seconds start to finish).
On ~80,000 records it takes about 80 seconds, huge perfomance decrease
No worries, I'll keep running tests and see if I can track down the issue elsewhere. The load process seems to be hogging less power now, so the problem may be elsewhere (or I may have fixed it by dropping the records once I got the filtered array).
Oh well, the time cost will have to do for now. Its at 92 seconds, with 52ish seconds due to the load and then output of the array. More coffee time I guess.
I might. I want to get more of it done and then upload it to GitHub so I have somewhere to link to. I have an idea of how I could get smaller chunks of the tables, but I dont know if it will be effective.
@Hosch250 Would be a shame to see you step back, but I do understand the need to broaden skills. FWIW, AvalonEdit/Intellisense will presumably be quite different from the parsing/analysis side of RD, and your work on Roslyn.
This CodeProject (registration required to download) has a really nasty VBA parser - granted it was written in 2003, but OMG, RD's parser is so much more robust.
@Mat'sMug/@M.Doerner I've got a "Module of Member 'Class1' has a description attribute but no annotation inspection... But the attribute is on the Event Foo (not the class) -is that possibly because the attribute parser fails to understand an attribute for an Event?
Maybe their economy would get a boost and they would stop just hiring people they know and start hiring people they view as "higher risk", such as minorities...
Yeah, and that's OK. But that's the setting we have, so yes, that's a problem for me.
I'm more likely to hire someone who is willing to learn and adapt even if they have less experience than someone who has 20 years doing everything his way.
I've recently learnt about the Model-View-Presenter architectural pattern and I wanted to give it a go with a simple VBA project.
The aim is to retrieve a person's name from a UserForm.
The userform looks like this:
A user should select a team, which updates the name field > Select a name b...
I want to list every file and directory contained in a directory and subdirectories of that directory. If I chose C:\ as the directory, the program would get every the name of every file and folder on the hard drive that it had access to.
A list might look like
fd\1.txt
fd\2.txt
fd\a\
fd\b\
fd...
VBA Rubberducking
VBA Rubberducking