RELOAD!

[Cardshifter/Cardshifter] 2 issue comments.

[Hosch250/Rubberduck] 4 commits. 2794 additions. 1164 deletions.

[rubberduck-vba/Rubberduck] 2 commits. 1952 additions. 579 deletions.

[Zomis/StackSTV] 2 commits. 20 additions. 12 deletions.

I win.

Of course, all I did was pull.

[ckuhn203/VBEX] ptwales pushed 22 commits to master (only showing some of them below)

[ckuhn203/VBEX] ptwales pushed commit 150d2bb2 to master: Compilable now

[ckuhn203/VBEX] ptwales pushed commit e5a52733 to master: Fixed HashSet/SortedSet interop

[ckuhn203/VBEX] ptwales pushed commit 40fe2d74 to master: Created hashset test file.

[ckuhn203/VBEX] ptwales pushed commit 4c5c2836 to master: Merge branch 'hashset' of github.com/ptwales/VBEX

[ckuhn203/VBEX] ptwales pushed commit c72f4682 to master: Attempting to add Access build supoort

[ckuhn203/VBEX] ptwales pushed commit f311a50a to master: Cannot for each over str

[ckuhn203/VBEX] ptwales pushed commit 816bbd4e to master: Updated Dict.Create is param

[ckuhn203/VBEX] ptwales pushed commit 76d19f0b to master: Maybe has default value

[ckuhn203/VBEX] ptwales pushed commit 60b068bf to master: Default member must be property for application.run

[ckuhn203/VBEX] ptwales pushed commit a5a2bf8f to master: Merge branch 'master' of github.com/ckuhn203/VBEX

What's next for RD?

[rubberduck-vba/Rubberduck] retailcoder pushed commit 07092b71 to next: added fluent transitions between builders

[rubberduck-vba/Rubberduck] build for commit 07092b71 on next: AppVeyor build succeeded

[Hosch250/Rubberduck] Hosch250 pushed commit 8701aeea to next: Clean refactoring tests up just a bit.

[Hosch250/Rubberduck] Hosch250 pushed commit 85a3dd9b to next: Merge branch 'next' of github.com/rubberduck-vba/Rubberduck into next

@Hosch250 moar tests :)

[rubberduck-vba/Rubberduck] retailcoder pushed commit 9bf01f24 to next: added de-DE in language dropdown

[rubberduck-vba/Rubberduck] build for commit 9bf01f24 on next: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] build for commit 9bf01f24 on next: AppVeyor build succeeded

And, I got my project building on AppVeyor!

Only have to figure out why 78 tests are failing on my machine and only 55 are failing on the build server...

Well... That's odd @Rossco. Lol

Is the build order set up so that everything builds?

@Mat'sMug that looks awesome, but why isn't there a Component builder that ProjectBuilder delegates to?

It could encourage us to pass project collections where all we really need is a component, no?

@RubberDuck because a component doesn't need a builder. Except user forms.

If you know what code you want and what type of component, you got everything you need already to mock any non-userform component

@Mat'sMug true enough I suppose.

I was just curious about it.

@RubberDuck it could have delegated to some ComponentFactory, but I thought it'd be overkill ;-)

I was just thinking of cases where we might only need a component, but you're right I think.

@RubberDuck that's covered with the BuildFromSingleModule method, which gives you a VBE and a VBComponent ready to use and all wired-up

[rubberduck-vba/Rubberduck] NeilBryant forked us into NeilBryant/Rubberduck

monking all!

Quick question: I've written Private Sub CheckDirExists(ByVal FullPath As String) that will recursively call itself with shorter path names until it finds something that exists, then build the path from there. Is CheckDirExists a good name?

Naming things is hard

@FreeMan Not really. I would expectCheckDirExists to return false if the original path I sent it is not a folder.

Maybe FindExistingParent ?

Also this might be relevant github.com/ckuhn203/VBEX/blob/master/src/fsview.bas#L48

@cheezsteak Seems like a reasonable answer. What would be a good name for "Send me a path (with or without a filename at the end) and I'll create whatever parts of the path that are necessary", yet still remains within the 127 character Sub name limit?

@FreeMan To be used with some shell operation like $ mv -p src dest? Basically I have a filepath that I want to move a file to but I don't know how many folder I need to create first?

Actually thats $ mkdir -p stackoverflow.com/questions/547719/…

Quack

@cheezsteak useful, but you missed the invisible vba tag... ;)

@Phrancis Qvack yourself!

@FreeMan I was correcting the mv -p. --parents is not an option of mv it's an option of mkdir.

@FreeMan MakeParents or CreateRootPath github.com/ckuhn203/VBEX/blob/master/src/shutilE.bas#L150

I think we're talking different things, @cheezsteak. I can find no references to any parameters beyond path for the mkdir function available to VBA programs running under Windows.

As usual, things are simpler in Linux

I am just thinking about your desires in VBA in terms of what is available in Linux

Also, I'm not looking to write (or borrow) the function, as I've already done that, just looking at naming it

MakeParents seems good to me then.

@Mat'sMug I've been looking at RenameUsages planning to fix the events bug, and I don't even get what that second section is doing.

@FreeMan why not just BuildDir?

You could always just document that it doesn't do anything if the directory already exists.

BuildDir and MakeParentDir seem like reasonable options. Why not use it? Because I didn't think of it, @RubberDuck!

@RubberDuck What is this... document ... of which you speak?

@Hosch250 link?

@FreeMan mythical beast. Related: unicorns

Ahhh... that makes sense

github.com/rubberduck-vba/Rubberduck/blob/next/RetailCoder.VBE/…

Sorry, @Mat'sMug, was reading.

@RubberDuck Got good news! Will let you know more when I'm out of here

@Phrancis excited to hear it!

Good News is Good!

[Hosch250/Rubberduck] Hosch250 pushed commit f4ac3ad6 to next: More rename tests

Congrats to @Mat'sMug & @SimonAndréForsberg, new CR moderators!

@FreeMan I'd better watch my P's and Q's then...

@RubberDuck You are finally getting that review for codereview.stackexchange.com/questions/84575/…

@Mat'sMug @RubberDuck I made this for you guys. github.com/ptwales/Rubberduck-Choco Idk if you care but if you don't mind I would like to push it to Chocolatey. Then I can more easily install rubberduck at work.

@cheezsteak cool! what is it?

Chocolatey is a opensource package manger for windows. It uses nuget to install packages other than just VS stuff

chocolatey.org

Basically you can choco install python GoogleChrome jdk8 etc

I want to be able to just choco install rubberduck so I built a package for <strike>you</strike> me!

nice

[rubberduck-vba/Rubberduck] stessler starred us

@Duga #67!

@cheezsteak Use ---text---, like this: text

@Hosch250 I thought we could use HTML and markdown?

or was that only in posts

Not in chat.

Markdown works, but not HTML.

Guys, how would you assess VBA code which doesn't specify types in method signatures or variable declarations?

@Rossco Like everything is a variant or implicitly a variant?

I guess that's the case (unless they are using DefXXX, which is worse).

I have a job interview in a couple and I was just reviewing some of their code.

And that was one thing which stood out to me.

They should have a reason for it to be variant.

Yeah and declare it explicitly?

As in 'this is a variant because I need a variant'?

Oh hey! Wow! Thanks @cheezsteak!

This is a variant because it could be an Array or a collection.

@RubberDuck Which the reveiw or the chocolatey package?

I'm talking about entire modules where every declaration (parameter or variable) is implicitly declared as variant.

That's just lazy

There should be a Long or Integer somewhere

@Rossco Just install RD and say "Look at all these problems with your code!"

Anything that is explicitly used as primitive type should be declared as that primitive type.

Both @cheezsteak!

I'd call it sloppy at best @Rossco. If things aren't typed, there are likely other issues. My question for them would be if they're dedicated to paying the tech debt.

@RubberDuck yeah, like, install Rubberduck, run inspections, "fix all", done ;-)

That ^. R# has been a godsend at my new job.