I think I made some adjustments to it (which I hope I pushed) but I see I'm one commit behind now.
If you think there is any useful code worth pulling in then go for it.
Hey guys, I was looking at the dependencies in RD and I noticed that Antlr is a dependency of both projects. After pulling on that thread for a while, I reckon that it might be possible to rationalise the dependencies with a little effort. Would you be happy for me to do that?
@RubberDuck Sorry, I'm writing about two different topics!!
The unit testing repo was an aside relating to what you were talking about above.
I had been reviewing the code as well and was asking about the refactoring. I just wanted to know if you were interested in that before I started working on it.
dependencies == references to external libraries.
I reckon if you push the RubberDuckParser class into the Parsing project and work on hiding the Antlr classes inside the parse tree nodes you can get rid of the Antlr library reference from the main project.
Oh. Yeah. I'm not sure where it's leaking right now, but for some reason Rubberduck.dll still needs a reference to the ANTLR runtime. I suppose it would be a good idea to contain it in the parser project, but that's @Mat'sMug's baby. I don't want to speak for him.
If you're going to look at it, I'd use the next branch. I just split things into multiple projects.
@Rossco the parse tree is ANTLR; unless code inspections and anything that needs a Declaration goes into the Parsing project, ... RD and ANTLR are one.
Refactor/rename uses an ANTLR TokenStreamRewriter, too.
Wrapping up ANTLR would be quite a colossal amount of work.