VBA Rubberducking

Duga

12:02 AM

RELOAD!

[rubberduck-vba/Rubberduck] 1 opened issue.

[Minesweeper] Games Played: 157, Bombs Used: 117, Moves Performed: 21283, New Users: 13

Mathieu Guindon

1:53 AM

2

tB needs private classes

and predeclared instances... I'm being forced to make a factory module for VBA code to be able to create and initialize an AppContext

hm we can hide them with an underscore prefix though

(gotta test that)

hm, nope, ValidationErrors.[_NewEnum] is showing up as NewEnum

Mathieu Guindon

2:29 AM

oh, modules are private lol

ok simple, just expose a parameterless constructor

interesting, ...somehow Rubberduck isn't seeing the tB types

Feeds

3:15 AM

As if these problems weren't NP-hard enough.

this

3:25 AM

@MathieuGuindon why the IDisposable is there?

Mathieu Guindon

mostly for this punk:

Private Sub IDisposable_Dispose()

    Set This.Context = Nothing

    This.Punk.Disconnect
    Set This.Punk = Nothing
    Disposable.TryDispose This.ValidationAdorner
    Set This.ValidationAdorner = Nothing

End Sub

in the PropertyBinding base class

'@Description("Encapsulates a property binding for a MSForms.TextBox target.")
class TextBoxPropertyBinding
    Implements IPropertyBinding
    Implements IDisposable
    Implements IHandleControlEvents
    Implements IHandlePropertyChanged

    Private Type TState
        Base As PropertyBinding ' composition > inheritance
        Notifier As INotifyPropertyChanged
        Handler As IHandlePropertyChanged
    End Type

    Private This As TState

Duga

[rubberduck-vba/Rubberduck] retailcoder opened issue #5733: Rubberduck doesn't seem to load twinBASIC types?

> ## ⏩ To Summarize
**A quick description of the problem:**
This could be a bug in Rubberduck's library loader, or just something weird with my twinBASIC library or my computer, or it could be that twinBASIC type libraries are [currently?] structured in a way that somehow sets them apart from other libraries, but it appears Rubberduck is currently unable to load/resolve a twinBASIC library.

CC @WaynePhillipsEA
twinBASIC version: 0.9.1602

## 🔁 To Reproduce
**Steps to reproduce the

[rubberduck-vba/Rubberduck] retailcoder added label bug to issue #5733: Rubberduck doesn't seem to load twinBASIC types?

[rubberduck-vba/Rubberduck] retailcoder added label typeinfo-processing to issue #5733: Rubberduck doesn't seem to load twinBASIC types?

Mathieu Guindon

@Duga thinking of tweaking the issue templates a bit, thoughts on that one? (the template would prompt for the RD version)

Mathieu Guindon

3:57 AM

damn, 0 problems and there's a .dll in the output folder, but the "debug console" is listing a bunch of [LINKER] compiler errors about what looks like missing default constructors

Public Sub New()
    GuardClauses.GuardExpression Throw:=True
End Sub

ooh we can make the default ctor private

this

are those predeclared? if so it’s not supported yet, i believe

@MathieuGuindon doesn’t it already? it asks to paste the version from rd about dialog

Mathieu Guindon

it does, but there's no big headings and emoji icons

"to summarize" / "to reproduce" / "to call it fixed"

this

add it in, use clipboard emoji, maybe?

mansellan

5:59 AM

twitter.com/WaynePhillipsEA/status/1382396651260813313

mansellan

6:52 AM

heh, onto page 2 already :-)

Duga

12:06 PM

[rubberduck-vba/Rubberduck] MDoerner added label enhancement to issue #5732: RemoveUnusedDeclarationQuickFix for assigned-only variables results in uncompilable code

[rubberduck-vba/Rubberduck] MDoerner removed label bug from issue #5732: RemoveUnusedDeclarationQuickFix for assigned-only variables results in uncompilable code

[rubberduck-vba/Rubberduck] MDoerner added label status-bydesign to issue #5732: RemoveUnusedDeclarationQuickFix for assigned-only variables results in uncompilable code

[rubberduck-vba/Rubberduck] MDoerner created comment on issue #5732: RemoveUnusedDeclarationQuickFix for assigned-only variables results in uncompilable code

> This behaviour is by design. In contrast to the declaration, the assignments can have side-effects. Accordingly, option 3 is out of the question as it can silently introduce subtle functional bugs.

We can still treat it as a possible enhancement to disable the quickfix if there are assignments. However, disabling it will likely raise questions on why the quickfix is not available for mysterious reasons.

Duga

12:53 PM

[rubberduck-vba/Rubberduck] BZngr created comment on issue #5732: RemoveUnusedDeclarationQuickFix for assigned-only variables results in uncompilable code

> So, is there a need for a VariableAssignedButNeverReferenced inspection? It would compliment the VariableNotAssignedInspection and would narrow the focus of the VariableNotUsedInspection to really-no-kidding-never-used declarations - and the QuickFix can be applied safely. Assigned but never referenced variables would still be flagged but would not offer a QuickFix.

FreeMan

1:23 PM

@MathieuGuindon Personally, I'm not a fan of communication via picture, too easy to misunderstand. Yes, the text is there, too, but... the emoji, they creep

mansellan

@FreeMan 😊

FreeMan

smacks @mansellan

mansellan

😎👏❤😍😒👌🎉🎂

2

FreeMan

ignores @mansellan. Looks for "block user" setting.

:)

seriously, what's that last one? Chocolate cake? A Minecraft block? Dirt with a little grass sprouting on it? THIS is why I despise graphic emoji. Simple old school text based ones are generally understandable. generally

this

@FreeMan you need to welcome your new emoji overlords. Soon we will no longer use text but communicate only by emojis.

FreeMan

1:37 PM

Because people are already so good at communicating with words...

this

We are now post-literate society! What a brave new world! applies for Fordship

FreeMan

Sees 1984 everywhere he looks.

this

TBH I see both everywhere.

FreeMan

1984 and Brave New World? I've not read the latter, though I should.

this

Yes, it's very good contrast.

Boot on your face only works if your boot is big enough and they can keep standing on your face for as long as they want.

Distracting them as to not need the boot on the face may be more expedient.

Either way, they've come to use both 1984 and Brave New World as instruction manuals. :-\

FreeMan

1:40 PM

Speaking of warnings of the future, I remember watching Fahrenheit 451 many (many) years ago and being very confused by it. I later discovered that it was intended to be a warning against the creep of TV and watched it again (funny, I've watched it twice, but never read it), and it made so much more sense.

@this Sadly very, very true.

this

@FreeMan wait, there's a movie about not reading?

FreeMan

oh the irony!

oy the ironing

this

lol

FreeMan

Wasn't there a time when that got an "autostar"? ah, the old days...

mansellan

I have to say, I'm loving the fact that twinBASIC issues are now on GH. It's kinda distracting me from my work though!

@this, fyi: github.com/WaynePhillipsEA/twinbasic/issues/36

this

1:48 PM

can of worms opened

mansellan

^

this

Seriously, good question. I would not want twinBASIC to end up accidentally evolving into VB.NET

VB.NET is just.... no.

mansellan

istr some bits are horrific. "lambdas" maybe?

this

oh yeah

and givent hat tB is unmanaged, no reason to follow VB.NET anyway

borrow only the good bits but go off in our own direction, basically

mansellan

sure, but from the opposite direction, no need to diverge just because. Imo, diverge if following would lead to unpleasantness...

BigBen

1:53 PM

"basically" ... bad pun

this

Agreed.

@BigBen Here's a pin for you!

#TIL C# 7.2 allows for in modifier

but reading through the specs quickly it doesn't seem to do anything useful...

Mainly because foo(int bar) is already a "ByVal" so that bar won't be changed after the call, and because foo(in someObject bar) won't guarantee that someObject.Mutate() isn't called within the called method.

Mathieu Guindon

2:11 PM

buys 🐤.com

(not)

this

@MathieuGuindon so is that a yellowchick.com?

oh wait, that's a goldenfinch.com, right?

Mathieu Guindon

emoji urls are coming and we're not going to like it

this

they should never come. I have no idea how I'd google it

2048: "Great news for Maine—we're once again an independent state!!! Thanks, @unicode, for ruling in our favor and sending troops to end New Hampshire's annexation. 🙏🚁🎖️"

Mathieu Guindon

Is 🥚@🐤.com a technically valid email address though?

2

FreeMan

I rest my case

this

2:24 PM

BRB buying a shotgun now....

FreeMan

good call

mansellan

3:10 PM

@this they're for readonly structs: devblogs.microsoft.com/premier-developer/…

this

Ok,now that makes more sense.

enforcing that UDTs and arrays aren't mutable should be doable.

enforcing that for objects is much more hard

e.g. did foo.ToString() mutate the foo? We don't know!

IvenBach

@FreeMan :waves:

FreeMan

3:35 PM

ha

Mathieu Guindon

3:46 PM

@this if it did, fire the author

(!)

Vogel612

@MathieuGuindon no, but 🥚🐤@farm.com is

this

@Vogel612 I'm going to assume that the original RFC was an April Fools joke taken seriously.

Vogel612

no.

the original RFC just said that the local adress isn't constrained

as long as the mail arrives at the host with the address unchanged that also should work perfectly fine

this

Well, that was probably pre-emoji, sooo....

I'm sure the author regrets his error now.

(or could it be a long con job?!?)

Vogel612

honestly even ;a horrible address, really;@[::1] is a valid email address

Mathieu Guindon

3:55 PM

^ and this is why the only thing you can reasonably validate in an email field, is the presence of an @ character

this

but you know 100s of providers are constraing it to alphabetic characters.

Vogel612

tbf, it seems prudent to require the host to be a name, not an IP-address for almost all cases

@this sure, but that's their business

this

So an email 🥚🐤@farm.com is most likely unusable. As it should be.

#ScrewRFC

Vogel612

mumbles something about conservative emission and liberal acceptance

Mathieu Guindon

alt="[:egg::ducky:]@farm.com"

this

4:00 PM

@Vogel612 probably one of the worst mistake behind the one-off mistake.

Mathieu Guindon

if tB is really going to have docstrings for the entire std library, would be nice if the docstrings could somehow be open-sourced so we could load them into RD and have stdlib docstrings in VBA/VB6 as well

(ref. github.com/WaynePhillipsEA/twinbasic/issues/26)

this

For the VBA/VB6 internal stuff, wouldn't it need to come from the docs.microsoft.com?

Mathieu Guindon

nah we're loading the type library and getting the docstrings from there

when they exist

this

and I guess they don't in the VBA7.dll or msvbvm60.dll.

Mathieu Guindon

all we'd need is some StdlibDocStrings.resx with a key for every identifier and then we could supplement VBA7.dll with them

actually not even a .resx file, any old plain-text format will do

(we don't need them translated)

(or do/would we?)

this

4:06 PM

well, docs.microsoft.com is "translated"....

IDK if there are any contents that's not machine-translated, though. I thought there were at least some but not sure....

Mathieu Guindon

I wouldn't want to hit docs.microsoft.com all the time though

this

Yeah

and they have this nasty habit of moving stuff because...

mansellan

@MathieuGuindon DROP%20TABLE%20Users;@me.com

this

should be ;DROP%20TABLE%20Users;; --;@me.com, I think

(guessing at the escaping here; you need the trailing -- to make sure you don't cause a syntax error which then won't execute your surprise

mansellan

@this heh yeh, my sql-foo is lacking

this

4:14 PM

this also assumes that it's being html-decoded. IDK how common it is to html-decode the string

Vogel612

@this probably not that uncommon

especially for stuff like entering this into a webform at some "contact us" area

or at the login of some email provider

this

OK. I thought it was usually done for query parameters, not necessarily the form-url-encoded payload

Vogel612

I'm just guessing, honestly

but given the number of times I read "please don't use %#,;": in your email" or something similar...

HackSlash

Which came first, the 🐤 or the 🥚 ?

I'll show myself out...

this

4:40 PM

@HackSlash why not both?

Quack Exchange

0

Q: Best way to copy data to a new sheet and reorganize it (VBA)

I'm writing a VBA program which copies and organizes data from one master sheet into numerous other sheets. One of the recipient sheets unifies all the data from the master sheet which holds the same id number into a single row. For this operation, I am looping through the master sheet for each i...

this

@this it just occurred to me that nobody eats chicken for breakfast. Eggs for breakfast, yes. Chicken breast for dinner, yes. Chicken breast and eggs for a meal? We must fix that!

Vogel612

4:56 PM

@this what you're looking for is oyakodon

FreeMan

@this well, eggs are kinda "pre-chicken" are they not?

mansellan

@FreeMan or are they "post-chicken"?

this

5:13 PM

@mansellan & @FreeMan no, they're chickens. Just a special case of chickens. See: squares and rectangles.

@Vogel612 #TIL

FreeMan

@mansellan "post-chicken" is the smelly stuff that gets shoveled out.

2

Vogel612

oyakodon literally means "parent and child on rice", soo :D

BigBen

lol

Vogel612

it's a bit like that "boiling the goat in the milk of it's mother" thing

this

@Vogel612 lol I wonder if someone made it out of spite.

FreeMan

5:17 PM

I'd guess they usually make @this out of chickens and eggs. No spite involved. Hopefully, no spit involved, either.

this

cancels the trip to Japan

Mathieu Guindon

5:39 PM

🥚 vs 🐤 is just a rephrasing of i++ vs ++i ...semantics!

mansellan

🐤++ vs ++🐤

Mathieu Guindon

🐤-- == 🥚?

then 🥚++ == 🐤

FreeMan

I quit

mansellan

@FreeMan Acheivement Unlocked!

Mathieu Guindon

lol

BigBen

6:09 PM

@FreeMan don't be a chicken.

this

@BigBen too bad his name ain't Marty McFly.

mansellan

Heh, Wayne seems to be getting inundated with the 23 years-worth of enhancements that MS failed to implement to classic VB...

IvenBach

7:18 PM

Hrm... Attempting to add the new RD.Settings.ProjectSettings as a default value isn't working. It doesn't show up in the Type dropdown. Changing the type manually in the designer doesn't update Settings.settings. I'm missing the obvious.

this

or I am. Is htere a app.config?

IvenBach

There is.

I remember Past-Iven faceplanted like this and couldn't add the type.

this

add it there and see what happens

tbh app.config and settings.settings is confusing

it's a ugly hack

IvenBach

Added it and it's unavailable from the dropdown.

this

clarify - what droddown

IvenBach

7:33 PM

Within Settings.settings the Type column dropdown.

this

maybe you type it in?

IvenBach

I've tried searching via Browse. RD.Settings isn't an option.

Tried typing it in but it doesn't change.

this

Ok forget the designer for a bit

open the app.config & settings.settings in a text editor

set it up so tha they are similar to what you see for general settings

IvenBach

In a non-VS editor?

this

Yes.

MANUAL OVERRIDE ENGAGE!

IvenBach

7:40 PM

Manually adding it then opening the designer shows the correct type.

Time to test.

BigBen

That feeling when the absolute crap software you use creates a helpful 112MB "RuntimeStatistics" text file containing 3.9 million lines of absolutely useless crap.

#FinancePeopleWhoCantCode

M.Doerner

8:15 PM

@IvenBach From my experience, it is best to open the settings in text mode. You can do that via the context menu of the solution explorer.

I have no idea what they thought when they build the default view on settings.

It is even worse for the code inspection settings.

AFAIR, they all appear in a single field.

IvenBach

8:45 PM

2021-04-15 13:40:30.1587;FATAL-;Rubberduck._Extension;Startup sequence threw an unexpected exception.;Castle.MicroKernel.Resolvers.DependencyResolverException: Missing dependency.
Component Rubberduck.UI.CodeExplorer.Commands.ImportCommand has a dependency on Rubberduck.Settings.ProjectSettings, which could not be resolved.
Make sure the dependency is correctly registered in the container as a service, or provided as inline argument. ---> Castle.MicroKernel.Handlers.HandlerException: Handler for Rubberduck.Settings.ProjectSettings was not found.

this

I think you were supposed to add something tot he Ioc

IvenBach

After adding a ProjectSettings parameter to ImportCommand I'm getting this IOC error. I don't know what needs updating to correct it.

this

thinking someone should document the steps required to update/cerate settings....

this is way too convoluted.

IvenBach

I don't understand enough to do it on my own.

this

no, it's convoluted.

the whole thing with settings.settings was to work around a problem with something something for setting up IoC without making the consumer take a dependency soemthing something.

Honestly I can't remember why it's that way now

you could review the closed PR? Issue? about using settings.settings for the background

but all more the reason to document this convoluted process

M.Doerner

8:55 PM

I will have a look at the IoC. I already have a hunch what is missing.

IvenBach

@this Sorry to ping. I searched for settings.settings there is no closed issue. Only Issue 4493 which is open.

M.Doerner

Wait, why have you added a ProjectSettings parameter to the constructor of a command?

That really cannot be registered in the IoC.

Did you want an IConfigurationProvider<ProjectSettings>?

this

Yes, he's adding a new settings service

hence he needs ot update the IoC registration to handle the new service for ProjectSettings

M.Doerner

There is nothing to update in the IoC for that.

It should just work.

However, you cannot inject the actual settings object.

Well, technically, you can method inject it via the command's parameters.

However, the concrete settings cannot be constructor injected.

IvenBach

I've added private readonly IConfigurationService<ProjectSettings> _projectSettingsProvider; to CodExplorerViewModel. I still don't fully understand it but seems like it isn't the CodeExplorers responsibility to handle a project setting. Hence I was trying add the parameter to the ImportCommand constructor.

M.Doerner

9:08 PM

Where do you need the settings?

If you need them in the ImportCommand, then you can inject the IConfigurationService<ProjectSettings> there.

IvenBach

^ For the FilesToImport(...) member.

M.Doerner

Constructor injecting the settings themselves cannot work: there is just one instance of the command over the entire lifetime of the duck.

It needs to get the current settings, i.e. it needs a service to get them.

IvenBach

But for the ImportCommand to have a service it needs to be injected.

The CommandParameter="{Binding SelectedItem, Mode=OneWay}" is being passed to the command.

Oh.... Since that is what is being passed to the command the provider should be included on the parameter?

M.Doerner

No, you should be able to constructor inject the provider.

In principle, you could pass the project settings in the parameters, but that gets a bit ugly with WPF.

The error message you got looks like you tried to constructor inject ProjectSettings instead of IConfigurationService<ProjectSettings>.

IvenBach

9:26 PM

Why does providing the ProjectSettings directly instead of via an IConfigurationService barf?

this

settings is just a value container. You want it to read from a setting file somewhere, not a default value when you new it up.

M.Doerner

Technically, it barfs because we do not register the concrete settings types; we only register the providers.

It really does not make sense to register the concrete types because that would mean that the settings could not change while RD is still running.

IvenBach

Because it is then tied to the concretion, instead of the abstraction?

M.Doerner

You would have to register a specific instance of the class.

Accordingly, you would always get the same settings.

Well, technically, you could register a factory.

However, it would still mean that the settings cannot change on a target that constuctor injects the settings.

Since the commands are registered in singleton scope, i.e. there is just one instance of them, the settings could not change anymore once the command class has been instantieted.

With the service however, you get the current version whenever you request the settings.

Greger

11:46 PM

[rubberduck-vba/Rubberduck]: 1318 stars vs. [decalage2/oletools]: 1508 stars

Transcript for