« first day (2690 days earlier)      last day (42 days later) » 

12:02 AM
[Minesweeper] 73 Games Played. 50 Bombs Used. 9154 Moves Performed. 12 New Users
[rubberduck-vba/Rubberduck] 3 issue comments
2 hours later…
1:38 AM
> Partially addresses the warnings from #5881

Because certain supertypes can have foreign names, they may require bracketing. However, we also need to handle cases where the supertype names might be already bracketed or contains qualified names (e.g. `Excel.Worksheet` or `VBAProject.Class1`), we need to be pessimistic about the legality of the name when resolving the supertype in the `TypeHierarchyPass`. The new method introduced will attempt to split the supertype name on the `.` and bracket
1:59 AM
[rubberduck-vba/Rubberduck] build for commit f77d87e8 on unknown branch: AppVeyor build succeeded
7 hours later…
9:40 AM
[rubberduck-vba/Rubberduck] build for commit c106c802 on unknown branch: AppVeyor build succeeded
@Duga Please also note that we have inspections relying on the supertype names, AFAIK. So, we should really only introduce brackets if we have to to make the name parsable.
4 hours later…
1:43 PM
> As I mentioned in the OP, this will cause the tests on the implicit worksheet inspection to fail because it does not handle the bracketed version. I want to avoid making it conditional to bracket the name because that would devolve into whack-the-mole game trying to find all possible offensive characters that could appear in a supertype name. When running the bracketed name via the expression parser in the TypeHierarchyPass, it gets stripped away for the purpose of comparing against other de
2:35 PM
> Just to take some notes based on the PR #5888 that may be relevant for full resolution of hidden interfaces.

The supertypes are also provided from the `Implements` statement, handled within `DeclarationSymbolsListener`. This is deferred until the resolution in `TypeHierarchyPass` and for that reason, the `GetText()` is used there. That made me wonder whether it was possible to implements a poorly named module. Thankfully, VBA does not seem to permit names like those:
Implements [Bad N
1 hour later…
5 hours later…
8:55 PM
10:26 PM
> Thanks for reporting this since it is a bug, indeed.

However, could you see whether this still occurs in a newer prerelease? This should be fixed since the overhaul of the inspection in prerelease
10:47 PM
> Thanks, I've just installed

You're right, it appears to be fixed now - the inspection is not showing.
11:47 PM
[rubberduck-vba/Rubberduck] 1433 stars vs. [decalage2/oletools] 1763 stars

« first day (2690 days earlier)      last day (42 days later) »