VBA Rubberducking

« first day (2256 days earlier) ← previous day next day → last day (924 days later) »

Duga

12:01 AM

RELOAD!

[rubberduck-vba/Rubberduck] 1 opened issue. 1 closed issue. 1 issue comment.

[Zomis/Games] 1 opened issue.

[Minesweeper] Games Played: 48, Bombs Used: 32, Moves Performed: 6700, New Users: 2

14 hours later…

Duga

2:08 PM

[rubberduck-vba/Rubberduck] MDoerner commented on Rubberduck.CodeAnalysis/Inspections/Concrete/AssignmentNotUsedInspection.cs of pull request #5541: AssignmentNotUsedInspection false positives - incorrect variable scoping and others

[rubberduck-vba/Rubberduck] MDoerner created comment on pull request #5541: AssignmentNotUsedInspection false positives - incorrect variable scoping and others

> Thinking a bit more about the Resume case, could you please add a test with a single overall error handler, whose OnErrorStatement is at the start of the method. Then there should be two assignments, one used and one not used. This should still return a result. I think, the way the code is set upright now, it will not.

[rubberduck-vba/Rubberduck] MDoerner edited comment on pull request #5541: AssignmentNotUsedInspection false positives - incorrect variable scoping and others

> Thinking a bit more about the Resume case, could you please add a test with a single overall error handler with a Resume, whose OnErrorStatement is at the start of the method. Then there should be two assignments, one used and one not used. This should still return a result. I think, the way the code is set upright now, it will not.

8 hours later…

Duga

10:11 PM

[rubberduck-vba/Rubberduck] BZngr synchronized pull request #5541: AssignmentNotUsedInspection false positives - incorrect variable scoping and others

Duga

10:29 PM

[rubberduck-vba/Rubberduck] build for commit 521146ed on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] BZngr commented on Rubberduck.CodeAnalysis/Inspections/Concrete/AssignmentNotUsedInspection.cs of pull request #5541: AssignmentNotUsedInspection false positives - incorrect variable scoping and others

[rubberduck-vba/Rubberduck] BZngr created comment on pull request #5541: AssignmentNotUsedInspection false positives - incorrect variable scoping and others

> @MDoerner First, thanks for the awesome review. I have updated all the code sections per your comments. If I did not directly reply to the code comment - you can assume the answer is 'Done'.

Regarding the initial general comments:
1. Line 231 concern: changed to a `switch` statement as recommended.
2. Line numbers: yes - original implementation missed the mark entirely. The correction was pretty straight forward though. Thanks for spotting this.
3. `Resume` is considered in the analy