VBA Rubberducking

Duga

12:00 AM

RELOAD!

[Minesweeper] New Users: 20, Games Played: 87, Bombs Used: 35, Moves Performed: 11139

RELOAD!

[rubberduck-vba/Rubberduck] 3 issues opened. 17 issue comments

mansellan

@this I've been thinking about that, and I think we're missing something. There's an interface between VBA and its host. For third party hosts, that's ths VBA (COM) API provided by the SDK. For Office, it's something lower (as hinted by Wayne). The obvious candidate is native funtion exports, which I suspect the VBA COM API wraps.

If so, that should be hookable, no?

So we can intercept or invoke the VBA call to "get me this stream" or "store this stream"

this

sure we can hook. That's not the issue.

The issue is finding where it is.

ThunderFrame did mention that he could find it via the PE

mansellan

I'm sure I've seen it on my travels

Just can't remember where

this

the other issue, however is that it's binary and not documented.

hm. Actually that maybe is not that bad since there are several malware analysis tool that already has decompiled the binary form

mansellan

Well, it's OLE structured storage, which has been well RE'd

Snap

this

12:14 AM

I was remembering ThudnerFrame saying that there were number of oddities and non-compliance with the specifications, IDK.

mansellan

Non-compliance with specs? Nope, that never happened with 1990s microsoft. Ask anyone.

this

let's kill the WPF designer

mansellan

@MathieuGuindon Language server probably would... Do all the heavy lifting in Core, compiled on Linux...

(and yes, I'm catching up with chat. Work's been insane...)

this

`// #TODO: ~~Port VBA COM Win32 APIs the entire Windows SDK to linux~~ ~~Complete the WINE project~~ Rewrite Windows from scratch

2

mansellan

@FreeMan Sure that's not a problem. I just have to remember where it is. It's on one of the VMs I haven't fired up in months. I'll get back to you (soon).

@this But that's the point - the duck's brains don't involve COM, or Win32, or WPF. Analysis of VBA code is entirely independent of those, and exactly what would go in a language server, in any language we choose. The (boring?) front-end UI and COM bits would be the only things tied to all the Windows gubbins.

We need a PoC. I should get on that...

Vogel612

12:43 AM

that turns the whole thing into a problem of using a .NET Core and .NETFX multi-targeted binary in a NETFX project

and honestly that's the better problem to have, innit?

mansellan

@Vogel612 Sorry, I'm still not explaining well... The back-end projects could be .Net Core (or... anything else). The front-end projects would stay as (decently old) netfx. No multi-targetting needed.

Vogel612

ohhh, so the language server would be the only thing in Core?

and the comms from the addin to the server would be netfx?

mansellan

Yeap. Could be Net Core. Or Rust. Or Python. Or VBA. ~~Or Java~~ let's not be silly.

Vogel612

well, we do have a Java version of the parser, so there's that ...

mansellan

Yep. But... Java.

Vogel612

12:52 AM

~deep sigh yea ...

aaaanyways, it's time for me to go to bed :)

Toodles!

mansellan

Night!

mansellan

1:04 AM

@this Nice find! I'll be installing that...

Duga

[rubberduck-vba/Rubberduck] D3vlin created comment on issue #5354: Unable to open Test Explorer

> I still have the same error with each pre-release.

Only version v2.4.1.5226-pre works for me

Duga

1:24 AM

[rubberduck-vba/Rubberduck] mansellan commented on Rubberduck.VBEditor.VBA/SafeComWrappers/VB/VBProject.cs of pull request #5390: Remove the project SCW from ProjectDeclaration

[rubberduck-vba/Rubberduck] mansellan created comment on pull request #5390: Remove the project SCW from ProjectDeclaration

> Yep, VB6 now matches PE behaviour.

[rubberduck-vba/Rubberduck] mansellan commented on Rubberduck.VBEditor.VB6/SafeComWrappers/VB/VBProject.cs of pull request #5390: Remove the project SCW from ProjectDeclaration

[rubberduck-vba/Rubberduck] MDoerner pushed commit c7ac2da0 to next

Remove ProjectDisplayName from ProjectDeclaration

This also removes the IVbProject ctor parameter.

[rubberduck-vba/Rubberduck] MDoerner pushed commit 302e1df8 to next: Fix export (to clipboard) for inspection results and todo items

[rubberduck-vba/Rubberduck] MDoerner pushed commit 433a57b3 to next

Enhance IVbProject.ProjectDisplayName implementations

They now first try to use the filename, then try to get it from the caption, but with enhanced handling when running into the VBE aPI bug and finally fall back to the BuildFileName.

[rubberduck-vba/Rubberduck] web-flow pushed commit d2d3f1fb to next

Merge pull request #5390 from MDoerner/RemoveProjectSCWFromProjectDeclaration

Remove the project SCW from ProjectDeclaration

mansellan

1:42 AM

@Duga waiting for you to tell me the merge went ok before I go to bed...

Duga

[rubberduck-vba/Rubberduck] MDoerner added label PR-Status: Conflicting to pull request #5387: Split refactorings

M.Doerner

@Duga I will fix the conflicts tomorrow.

mansellan

@SimonForsberg @Duga should give a random humanish response when she's pinged without the ping being a reply...

@Duga Bah, it's not quite identical - PE picks up a project save immediately and adds the .vbp extension. CE only picks it up on reparse. Meh.

@M.Doerner, fyi

Suspect the underlying problem is not detecting project save -> reparse

Duga

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.0.5355

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.0.5355

[rubberduck-vba/Rubberduck] build for commit d2d3f1fb on next: AppVeyor build failed

mansellan

1:58 AM

@Duga AV fail... ttgtb

this

3:43 AM

A graphic designer I am not.

At least some elements changes but the colors are kind of off in some places.

it doesn't help that XAMl designer is simply useless for previewing changes what with it whining about can't find controls etc. etc. so I'm just setting windows color randomly.

Quack Exchange

5:39 AM

0

Q: Adding items to Collection using VBA

I am storing Table Header values into a collection using an OOP approach with VBA. Being new to this OOP approach, am I breaking any rules in the way my Public Property exposes how the values are retrieved in the For Each Loop, should I be defining this in a Sub Routine or Function instead? Publ...

Simon Forsberg

10:35 AM

@mansellan No

M.Doerner

11:24 AM

@Duga That is new: error 500 on code analysis XML upload.

Vogel612

11:37 AM

interestingly when uploading to github and not for anything else

I kicked AV for now, I assume github fixed itself there

M.Doerner

11:49 AM

Let's see whether I messed up resolving conflicts for my other PRs.

mansellan

@SimonForsberg lol

M.Doerner

@mansellan The CE does not update before the next parse for VBA as well.

Well, before the PR, it did not update at all.

Cashing issue

mansellan

ah ok

Duga

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot created draft prerelease Prerelease-v2.5.0.5356

[rubberduck-vba/Rubberduck] rubberduck-vba-releasebot prereleased draft prerelease Prerelease-v2.5.0.5356

[rubberduck-vba/Rubberduck] build for commit d2d3f1fb on next: AppVeyor build failed

BUILD FAILURE!

M.Doerner

Now, the 500 is on the content hash.

Duga

12:03 PM

[rubberduck-vba/Rubberduck] MDoerner synchronized pull request #5387: Split refactorings

[rubberduck-vba/Rubberduck] codecov[bot\] edited comment on pull request #5387: Split refactorings

Duga

12:20 PM

[rubberduck-vba/Rubberduck] MDoerner synchronized pull request #5384: Let declaration inspections use base classes

[rubberduck-vba/Rubberduck] build for commit 0abf2d83 on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] codecov[bot\] edited comment on pull request #5384: Let declaration inspections use base classes

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/5384?src=pr&el=h1) Report
> Merging [#5384](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/5384?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/d76917c082ea269f8bceb9ecc46c61cc613c39d5?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.

```diff
@@ Coverage Diff @@
## next #5384 +/- ##
=======================================

[rubberduck-vba/Rubberduck] build for commit d76917c0 on unknown branch: Coverage not affected when comparing d76917c...d76917c

[rubberduck-vba/Rubberduck] build for commit 0abf2d83 on unknown branch: 61.73% (target 0%)

[rubberduck-vba/Rubberduck] codecov[bot\] edited comment on pull request #5387: Split refactorings

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/5387?src=pr&el=h1) Report
> Merging [#5387](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/5387?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/c4ad4c82cf148c6ffeb168911397f35f5c79d249?src=pr&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `28.83%`.

```diff
@@ Coverage Diff @@
## next #5387 +/- ##
=======================

[rubberduck-vba/Rubberduck] build for commit 0abf2d83 on unknown branch: 28.83% of diff hit (target 60%)

Duga

12:36 PM

[rubberduck-vba/Rubberduck] build for commit cf659ec5 on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] build for commit cf659ec5 on unknown branch: 61.26% (target 0.00%)

[rubberduck-vba/Rubberduck] codecov[bot\] edited comment on pull request #5384: Let declaration inspections use base classes

> # [Codecov](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/5384?src=pr&el=h1) Report
> Merging [#5384](https://codecov.io/gh/rubberduck-vba/Rubberduck/pull/5384?src=pr&el=desc) into [next](https://codecov.io/gh/rubberduck-vba/Rubberduck/commit/d2d3f1fbbb811af10a3efb669490ae7971f8ddec&el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.

```diff
@@ Coverage Diff @@
## next #5384 +/- ##
=================================

Duga

2:42 PM

[rubberduck-vba/Rubberduck] SmileyFtW added label bug to issue #5396: Inconsistent TE Behavior

[rubberduck-vba/Rubberduck] SmileyFtW opened issue #5396: Inconsistent TE Behavior

Duga

3:05 PM

[rubberduck-vba/Rubberduck] Vogel612 added label feature-unit-testing to issue #5396: Inconsistent TE Behavior

[rubberduck-vba/Rubberduck] Vogel612 added label wpf to issue #5396: Inconsistent TE Behavior

M.Doerner

5:13 PM

I have to admit, using the Haskell State monad needs some getting used to.

Duga

7:07 PM

[rubberduck-vba/Rubberduck] MDoerner removed label PR-Status: Conflicting from pull request #5387: Split refactorings

[rubberduck-vba/Rubberduck] MDoerner removed label PR-Status: Review Requested from pull request #5390: Remove the project SCW from ProjectDeclaration

[rubberduck-vba/Rubberduck] MDoerner added label PR-Status: Conflicting to pull request #5357: Issue5346 extract interface creates private classes

Duga

8:54 PM

[rubberduck-vba/Rubberduck] MDoerner commented on Rubberduck.Refactorings/Abstract/CodeOnlyRefactoringActionBase.cs of pull request #5387: Split refactorings

M.Doerner

11:47 PM

Wow, it took me an entire day to refactor a single Haskell module (my solution for AdventOfCode day 5).

Now, I just have to add the remaining functionality for day 7.

Transcript for