RELOAD!

[rubberduck-vba/Rubberduck] 1 opened issue.

[Minesweeper] Games Played: 124, Bombs Used: 79, Moves Performed: 15665, New Users: 11

Not much chat, but lots of releases in the last 5 days. I'm thankful! Hope y'all had a great Thanksgiving weekend/26-29 Nov (as determined by the customs in your locale).

[rubberduck-vba/Rubberduck] Flowman74 starred us

[rubberduck-vba/Rubberduck] SmileyFtW created comment on issue #4169: New Unit Test Added inside existing Unit Test

> If the cursor is on the last line of the test module AND the last line of the test module is the one immediately after the End Sub of the previous procedure then the newly added test method ends up just ahead of the End Sub resulting in 2 End Sub lines. If the last line of the test module is 2 lines after the End Sub then all is well, but the first line of the added test text ('@TestMethod("Uncategorized")) is immediately beneath the End Sub of the previous procedure. Seems like a

[rubberduck-vba/Rubberduck] IvenBach created comment on issue #4169: New Unit Test Added inside existing Unit Test

I believe we have code somewhere that add/removes a line to workaround a VBIDE bug in import process

[rubberduck-vba/Rubberduck] IvenBach created comment on issue #4169: New Unit Test Added inside existing Unit Test

> Tested this with Version 2.5.1.8557 and not getting OP behavior. Try with a more recent copy of RD and let us know if it's been resolved.

I was still working under the assumption it needed the extra line.

Wanted to see where next is compared to the prereleases. Reading the manual I tried --tags=tag and --tags=Prerelease with no results showing.

@IvenBach git describe looks to be what I wanted.

@IvenBach only works for annotated tags, though

The prerelease aren't annotated tags?

Reading time: git-scm.com/book/en/v2/Git-Basics-Tagging

@IvenBach appveyor doesn't support annotated tags, or at least I didn't find the option when I set it up

and the prereleases IMO shouldn't be annotated tags in the first place.

Reason being is they are just a marker (pointer) to a specific commit?

There's nothing special about them other than they are automatically created?

reason being that they should be cleaned up because two green releases later they are supposed to be useless

green release tags should be annotated (because they should be "eternal")

Green release is the summary of all the prerelease tags?

no

green release is merge into main

and green release also means "hey, we think this is stable"

for some values of "think" and "stable". ;)

yes

Tags are still a vague concept for me.

on that note: we should consider doing another green release, because there's some really nice new features

TBH, it's been forever since I've had any crashing in Office apps even vaguely related to RD...

@IvenBach "immovable branches"

Aren't branches already immovable since they start at a specific commit?

checkout a tag and commit something to find out the difference

could I say that tag = snapshot of the repository at that specific commit for that branch?

that's true for every commit, though...

it's probably more accurate to say:

tag: Easier name for a special commit
annotated tag: Tag with attached release notes

Docs state and testing confirms a detached head state when checking out a tag.

[rubberduck-vba/Rubberduck] IvenBach commented on Rubberduck.CodeAnalysis/Inspections/Concrete/EnumerationDeclaredWithinWorksheetInspection.cs of pull request #5638: Add inspection to find enums declared within a worksheet

[rubberduck-vba/Rubberduck] IvenBach synchronized pull request #5638: Add inspection to find enums declared within a worksheet

[rubberduck-vba/Rubberduck] build for commit 60e40200 on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] IvenBach added label feature-inspections to issue #5642: Flag implicitly public enumerations as such

[rubberduck-vba/Rubberduck] IvenBach added label up-for-grabs to issue #5642: Flag implicitly public enumerations as such

[rubberduck-vba/Rubberduck] IvenBach added label enhancement to issue #5642: Flag implicitly public enumerations as such

[rubberduck-vba/Rubberduck] IvenBach opened issue #5642: Flag implicitly public enumerations as such

[rubberduck-vba/Rubberduck] BZngr review_requested pull request #5638: Add inspection to find enums declared within a worksheet

@Duga user error :(. Trying to approve the changes.

[rubberduck-vba/Rubberduck] IvenBach created pull request #5643: Include enums in ImplicitPublicMemberInspection to merge IvenBach/Rubberduck/Issue5642_flag_implicitly_public_enumeration into...

rubberduck-vba/Rubberduck/next

> Close #5642.

For the record, I 100% agree we need a RD 2.5.2 before 12/22

[rubberduck-vba/Rubberduck] BZngr commented on Rubberduck.CodeAnalysis/Inspections/Concrete/ImplicitPublicMemberInspection.cs of pull request #5643: Include enums in ImplicitPublicMemberInspection

(2.5.0 was 2019-12-22)

Gotta get a couple more PRs merged first though =)

[rubberduck-vba/Rubberduck] build for commit 6228cb6f on unknown branch: AppVeyor build succeeded

[rubberduck-vba/Rubberduck] IvenBach commented on Rubberduck.CodeAnalysis/Inspections/Concrete/ImplicitPublicMemberInspection.cs of pull request #5643: Include enums in ImplicitPublicMemberInspection

@Duga Digging a bit it looks like UDT with implicit public access are being flagged as Public and that is what causes the result to not populate.

Anyone able to point me in the direction of where to begin unraveling how a declaration is parsed and resolved?