> Must be a bug with the busy state of the inspection results viewmodel - triggering a reparse from the RD commandbar or main menu should bring it back to normal, after a successful parse and inspection run.
> I get that WPF will autohide controls that can't fit but I think this just looks too weird: 
Kind of expect that the label and combobox would be a package deal.
> My guess is that the parser state says "I'm already all up-to-date" and never fires a "state changed" event with the "ready" state the viewmodel is expecting; if that's the case then modifying the content of a single module (a single character suffices) and reparsing, would fix the state glitch.
> Replicated locally. This appears to be due to the command not running on the UI thread.
``` Exception thrown: 'System.ArgumentException' in Rubberduck.VBEditor.dll 2018-12-13 17:53:39.0483;ERROR;Rubberduck.UI.Command.ReparseCommand;System.ArgumentException: Expected COM object, but validation failed. at Rubberduck.VBEditor.ComManagement.TypeLibs.TypeLibWrapper..ctor(IntPtr rawObjectPtr, Boolean isRefCountedInput) in C:\Rubberduck\Rubberduck.VBEEditor\ComManagement\TypeLibs\TypeLibs.cs
> Hmm.. Ignore what I said then - this is another thing entirely. That said there is a busy state glitch when a reparse is requested from the inspection results toolwindow, and then cancelled ...but for that the code must be uncompilable and the parser setting for 'compile before parse' must be enabled.
> BTW - there is a utility to expand Excel 2010 32bit to use all of the 4GB rather than 2GB - I had forgot to use this utility on the latest version - which I have done now - maybe that will solve the memory constraints
(how software development feels)
A: How can we put in this screw with a hammer?
B: Why a hammer?
A: We were told a hammer is what everyone is using and we should use it too.
B: Please don't...
(some time later)
A: We hammered the screw in and it's not working well. Help!
> There are many variations to the MVP pattern. The Partner Portal application uses the Supervising Presenter approach (this is also named Supervising Controller).
not necessarily wrong, just a different snowflake =)
> Rubberduck.Setup.2.3.1.4308.exe (3.89 MiB) - downloaded 268 times. Last updated on 2018-12-10
> Rubberduck.Setup.2.3.0.4221.exe (3.88 MiB) - downloaded 488 times. Last updated on 2018-11-25
@IvenBach looks like a web implementation. look for WinForms stuff=)
Any opinions on where random WPF extension methods should live?
This needs a home:
public static T GetDescendent<T>(this DependencyObject parent, Func<T, bool> filter = null) where T : DependencyObject
{
for (var index = 0; index < VisualTreeHelper.GetChildrenCount(parent); index++)
{
var child = VisualTreeHelper.GetChild(parent, index) as T;
if (child != null && (filter is null || filter.Invoke(child)))
{
return child;
}
var descendent = child.GetDescendent(filter);
> Yes, VBProject isn't available via the Outlook object model. When I was searching for a solution, I have just found (maybe false) information that there is no possibility to export the code from Outlook. I have currently a working way to get this using olevba, I am just looking for a solution that doesn't need the extra tools (and Python). Edit: It is not possible to get the reference from VB extensibility objects either...
> I wonder though, does this need to be permanently on show on the toolbar? Seems like Settings would be a better home for this, with a cog icon on the toolbar to jump there.
> I agree settings would be a better place for this. If it's not moved there, a fix to keep the label and dropdown together could be to simply wrap the two controls in a <StackPanel Orientation="Horizontal"> tag.
Especially in light of #4635 would it be possible to parse all installed plugins when the RD starts up and write them to the log with the other environment settings or put them in the About dialog box to be copy/pasta'd when reporting a bug?
In the log could be considered (by some) a privacy issue since it reports what you're running and a lot of people (me) wouldn't look at the log before submitting, but the About box just copies info to the clipboard which the user pastes into the bug report - in theory they should read through what they've just pasted & could remove something if they felt it was necessary.
These are the questions that end up getting asked of those who are reporting these types of issues. I'm just thinking that it would be handy to get them answered up front.
> I agree that setting is also a better place but only if it affects more than just CE. Surely the font change would be useful everywhere, not just in CE, no?
> Especially in light of #4635 would it be possible to parse all installed plugins when the RD starts up and write them to the log with the other environment settings or put them in the "About" dialog box to be copy/pasta'd when reporting a bug? Additionally, reporting the installed memory, and if possible, the amount currently in use by the host app would be some extra credit bonus points.
In the log could be considered (by some) a privacy issue since it reports what you're running and a lo
@this @FreeMan hold on so the name of an unknown 3rd-party add-in built in-house that nobody knows anything about, is a privacy concern? I don't see the problem. It's not like we're tweeting "FreeMan is running MZ-Tools, the traitor!" or anything like it....
@MathieuGuindon no, but GDPR (or whatever just went into effect this summer in the EU) is pretty broad. By pasting it in the bug report and submitting, the user is "consenting" to give us the info. By "hiding" it in the log, it's less discoverable.
@MathieuGuindon Yup - when I first started posting issues, I looked at the first log and hadn't a clue what I was look at. I've got a better idea of what I'm seeing in there now, but there's still a lot I'm not groking. If "environment" were the first 10 or 20 lines, I'd probably recognize that and edit if I felt it was necessary.
I'm not saying that the About box is better than the log - I was just pointing out that it might be considered (by some) an issue, and proposing an alternative .
One could, without a doubt, edit things out of the log before submitting. Putting it in the "about" box data makes it more discoverable that this info is being provided.
I'm up for either/both methods - I just wanted to point out that some might consider it an issue.
Yeah, I like the idea of an email-like format where log & environmental is shown so they can click the button to send. Easy to send us a new issue without going "I did not realize you knew so much about me!"
> I very much like the idea, but most users don't bring up the about box to post this info, they just upload the logs. By uploading logs, they consent to share its contents. I have a hard time believing someone that's concerned about privacy (however irrelevant and petty that might be in the case of RD logs), would just blindly upload a plain-text log file without first vetting its contents.
true. but if they didn't include it in the first post, it's a very simple thing to ask them for in a follow up instead of asking 10 questions (roughly ;) as happened in #4635.
weird... I generated some reports for October data last month. I compared the October month data in last month's report to the October data in the Nov report I just produced - there were some mismatches! I pulled the copy of the Oct report I emailed to my boss - the Oct data in that copy exactly matches what I just produced in the Nov report. I now have no idea where the copy I have stored came from.
> I very much like the idea, but most users don't bring up the about box to post this info, they just upload the logs. By uploading logs, they consent to share its contents. I have a hard time believing someone that's concerned about privacy (whatever is deemed "sensitive" in RD logs...), would just blindly upload a plain-text log file without first vetting its contents.
Yeah, unfortunately we often get that - the data is collected on iPads, and they'll drop off the wifi and quit syncing. We have a "monitor" who is supposed to ensure (once a month) that it's online and has sync'd all data and reports to me that this has been checked. Even with that, I just found 5 records for Oct that didn't sync & get loaded until yesterday.
the weird thing is that my network stored copy of the "final" report had different numbers on it than the copy in my sent items folder in Outlook. Those were supposed to be the same report and shouldn't have been different.
Fortunately, none of this is that mission critical. They're just customer surveys. Though, with the amount of angst that flows when the numbers dip, you'd think a 0.01 drop in NPS was the same as loosing $5 Mil in a month.
well, on the bright side, my numbers now match what I reported last month so I can send this month's report out.
Sorry to hear that. Hope you don't miss the Christmas party and that it doesn't ruin your vacay - it's pretty obvious you've been looking forward to it.
On a totally unrelated note, this is something you don't often see when doing some online shopping:
Special On sale today only! 50¢ more, just for our valued customers. Join our Insiders program for insider pricing, you could pay 99¢ more!
> > If that is the case, then the workaround would be to define the class procedure as taking a Variant rather than an ParamArray. If the class procedure is public/friend, then both the class procedure and the interface procedure should call an internal procedure that takes a Variant rather than ParamArray.
This is a much easier and cleaner approach. The minor difference is that instead of having a list of items in the parameter list, the list of items is enclosed in an Array() statement.
I would much rather live in the city of poo falls, than the city of poo lake. I'd also much rather live in the city of poo falls than the City Below Poofalls... — Haakon Løtveit2 days ago
> I can definitely see a change signature refactoring that, when changing a ParamArray to a Variant, changes the call sites from foo, bar, 42 to Array(foo, bar, 42).
@this change signature can't work atm; for that we need to know exactly when a signature is modified, and offer the refactoring immediately (like R# does). picking up that the last parameter was ParamArray and now it's Variant, we could offer to modify the existing call sites accordingly...
change signature doesn't change a signature, it merely propagates to call sites changes made by the user to a signature
but that's a different solution than the one I was suggesting.
furthermore, it changes the semantics - with a Variant, it is now possible to send in an non-array parameter, which can muck up the works if you are not handling for both non-array and array parameters.
> If that is the case, then the workaround would be to define the class procedure as taking a Variant rather than an ParamArray.
if there are existing callers, they're broken
or I misunderstood which procedure "the class procedure" stands for.. the whole setup on that issue is confusing, with the interface uselessly mudding the waters
> If the class procedure is public/friend, then both the class procedure and the interface procedure should call an internal procedure that takes a Variant rather than ParamArray.
it was not clear to me (at that time) whether it was a private procedure.
IOW, instead of daisy chaining the ParamArray procedures, they should redirect to an internal procedure which means no change on the public interface is needed.
(mind, I use the word "interface" more loosely here)
Right. So, if they opt to change from ParamArray to Variant, they're welcome to it, but that does means more than just changing the call signatures since the interface is now different.
@this yeah. there's a reason RD doesn't have a change signature refactoring - it's a complicated one, ...might be even more complex than extract method!
@Duga FWIW I think we are basically scot-free in that regard, but our users may not be. AFAIK we're explicitly trying to not log any code unless the log-level is TRACE
if we made that a policy we could make the settings page give a warning when the user selects TRACE
we'd probably need to review all logging calls and make that an explicit guideline for contributors, as well as checking for it in PRs, but I think it might be worth the effort
unintentionally sparked quite the debate. Don't forget, the log is being manually provided by the user reporting an issue, not automatically uploaded. Usually, a new user would have to be prompted to provide it anyway. We could provide a warning with that prompt on the GH issue. This, of course, requires everyone here to remember to do that when issuing the prompt...
frankly, the first time I looked through the log, I was more baffled by seeing somepath\comintern\somemorepath or path\hosch250\file than anything I'd written...
@Vogel612 - that was explained to me - more than anything else, that is what stood out, not that there was a procedure name of mine in there - I'd expected to see that.
I think at this point, the UK should assume a hard-Brexit is going to happen and start talks directly with their neighbors and trade partners to get deals in place in case it does.
Worst case, a hard-Brexit happens and they already have deals signed that go into effect the same day, or ready to sign. If they don't, worst case is a hard-Brexit happens and there are a few weeks or months or years of deadlocks with bad blood growing because of the time in which trade, etc deals aren't in place.
ugh. broke my own rule that all DB changes should be scripted and stored in carefully named files so that as dev changes are made they can be properly played back into production when the associated VBA code is moved to prod.
Spent 1/2 of yesterday and all day this morning trying to figure out what the heck was wrong - One table didn't get updated. :(
> I tried to upgrade Rubberduck from `v2.3.0.4221` (which worked splendidly) to `v2.3.1.4308` and was greeted with the following error upon opening the VBE:
BigBen raises a good point: your arrays aren't initialized, so assigning to an index will throw error 9 / index out of bounds - unless you've simply omitted the Class_Initialize handler that initializes them. — Mathieu Guindon6 secs ago
@BigBen the "hackish" thing is to have a Property Let(variant) assign to an object reference - it works, but it's not idiomatic and makes for rather confusing client code (no Set keyword, but assigns an object reference? wtf?!)
I have a script that we are using to update our ERP database to a new version,
UPDATE ENUM_CODES SET COLUMN_NAME = 'PAY_STATUS' WHERE TABLE_NAME = 'PAYABLE' and COLUMN_NAME = 'STATUS'
/
but i dont know why it has the / after the update portion.
Does anyone know what that / means?
> `C:\Projects` is an artifact of the .pdb debugging info from the build server - that directory is where RD is being built, in the AppVeyor CI environment: it can be ignored.
The assembly pubic key tokens aren't sensitive at all, they're just *public* IDs for known assemblies, namely `Office.dll` v12.0 in this case (key tokens are identical for that assembly, on every machine in the world); the 12.0 is from the Primary Interop Assemblies we're building with: it's the earliest version Rubberd
@MathieuGuindon just checking - office will still be 12.0 even though they're using later office version?
he say he's using 2016, and I almost thought there was a version mismatch but I actually don't know for a fact if the PIA loading will automatically show the latest version like VBA would do with its host's object model reference.
> Wait a minu The fact that access was denied makes me think that there is some external factors involved. So we need to follow up with some questions
1) Was the workbook read-only, or on a read-only media? 2) Was the file in a trusted location? 3) Did you try to open the VBE without enabling the contents? 4) Can you reproduce with a different or a blank workbook? 5) Given that you are the only one to experience this, can you compare the add-ins you have installed (both Excel and VBA)
> The fact that access was denied makes me think that there is some external factors involved. So we need to follow up with some questions
1) Was the workbook read-only, or on a read-only media? 2) Was the file in a trusted location? 3) Did you try to open the VBE without enabling the contents? 4) Can you reproduce with a different or a blank workbook? 5) Given that you are the only one to experience this, can you compare the add-ins you have installed (both Excel and VBA) between you a
2018-12-14 13:29:31.0385;FATAL-;Rubberduck._Extension;Startup sequence threw an unexpected exception.;System.IO.FileLoadException: Could not load file or assembly 'office, Version=12.0.0.0, Culture=neutral, PublicKeyToken=<REDACTED>' or one of its dependencies. Access is denied.
File name: 'office, Version=12.0.0.0, Culture=neutral, PublicKeyToken=<REDACTED>'
at Rubberduck.VBEditor.SafeComWrappers.VBA.VBE.get_CommandBars()
at Rubberduck.Root.RubberduckIoCInstaller.RegisterConstantVbeAndAddIn(IWindsorContainer container) in C:\projects\rubberduck\Rubberduck.Main\Root\RubberduckIoCInsta…
@this it's a System.Exception thrown after the msgbox is shown; stack trace points to Extension.cs line 240
throw new Exception("Rubberduck's startup sequence threw an unexpected exception. Please check the Rubberduck logs for more information and report an issue if necessary");
I have a script that we are using to update our ERP database to a new version,
UPDATE ENUM_CODES SET COLUMN_NAME = 'PAY_STATUS' WHERE TABLE_NAME = 'PAYABLE' and COLUMN_NAME = 'STATUS'
/
but i dont know why it has the / after the update portion.
Does anyone know what that / means?
VBA Rubberducking
VBA Rubberducking