As a VBA programmer, I want to be able to see the modules and types defined in the standard library in the code explorer, so that I can easily browse all those pesky enums instead of looking them up on MSDN.. and then I can also easily find all references to any of them throughout my code.
> Using Moq, we only need to mock up the VBE functionality that actually gets called upon. I've not looked at the code you're talking about, but it might not be as hard as you think to Moq a VBE to inject. I'm not arguing against cleaning code up, but it might not be a prerequisite.
One big stumbling block was the Window object. I have a Mock in the source control branch that alleviates that. The feature isn't done, but it is in a place where I can merge the changes.
> The one thing that bothers me above all is that the quickfix functionality is implemented inside the InspectionResult classes - which is clearly a violation of SRP. Splitting the concerns here would help temove the VBE dependency from the InspectionResult classes.
@RubberDuck @Mat'sMug Hey guys, I would comment against the GH comment you CCed me in but I can't remember my GH password since I'm not at home. You can change the installation directory to whatever you want. However I suspect there could be issues if you try to use the Program Files dir.
The reason is that the installer is either in 32 or 64 bit mode. It decides which one based on the bitness of the OS when you run it. So when you launch it in 64bit Windows it runs in 64 bit mode irrelevant of what bitness of Office there is.
That's why I moved the default installation dir to the app folder.
Unfortunately I cannot evaluate a condition to decide what mode I want the installer to run in.
> Actually this might be more of a "bells and whistles" than anything else. You can already find all references of any built-in declaration by right-clicking them in the code pane.
I'm pretty sure that when an application asks for something from the PF dir Windows looks at the bitness of the process and gives it the corresponding directory.
since a 32 bit process cannot understand a 64 bit binary and vice versa.
the process being the Office application.
Windows may just let you do what you want if you provide a full path, I'm not sure.
> Somehow commit 3a483871 magically fixed this... except the selection glitch is causing another issue here, it's selecting one line above, which can result in non-compilable code - this snowballs into a NoViableAltException in ANTLR generated code.
Carlos J. Quintero (MZ-Tools articles & help with VBE API)
Code Review Stack Exchange
@daFreeMan
@Duga SE chat bot
Francis Veilleux-Gaboury
Frank Van Heeswijk
@Hosch250
JetBrains ReSharper Community Team
Knjname developer blog (clockahead.blogspot.jp)
Michal Krzych (vba4all.com)
@mjolka
Philip Wales
Ross Knudsen
Simon Forsberg
All contributors to our GitHub repository
All our stargazers, likers & followers, for the warm fuzzies
...and anyone reading this!
yeah at my old job I had written an app that was scheduled to tweak a .iss script based on some configuration settings, and then run it; then there was a scheduled task on all production servers that ran that app in a "deploy mode" that ran the installer and sent an email notification when it finished
Find all references to built-in #VBA constants, enums, functions... Get #Rubberduck today! https://github.com/retailcoder/Rubberduck/releases/tag/v1.3.0.1 http://t.co/dSWAtB2TFe
> Version 2.55 - This WGL4 version of Courier New was first supplied with the Final Windows 95 euro update that shipped on 4 November 1998. This version contains the euro.
> @retailcoder out of curiosity, did my blog about unit testing with rubberduck show up in your search? It's getting a fair bit of traffic. Perhaps a re-blog is in order?
Didn't seem to like functioning too well when installed over the top of 1.22, so I uninstalled both, reinstalled 1.3.0.1 (n.e.e.d.s. .m.o.r.e. .d.o.t.s) and all is good
I had modified the install path for 1.22 when I installed it after the first 1.3 fiasco, to be c:\PF\rubberduck (eliminating the second level of rubberduckiness), and thought that would work.
> Rubberduck is an add-in, and we're not packaging any kind of docs or other programs with it. The installer shouldn't try to create a start menu. Minimally, it should have `Don't create a Start Menu folder` checked by default.
> That thought occurred to me as well... but then seeing it was putting an uninstall link and a link to rubberduck-vba.com, I thought it might not be a bad idea at all.
> I don't know what more to say. Whether I select a procedure name, or if I try to do this from the Code Explorer, it doesn't do anything at all.
I can understand if this doesn't work for Procedures (it would be nice if it did!), but we shouldn't have it available in the Code Explorer context menu if it can't be used.
@RubberDuck if the procedure is used in another project, it won't pick it up, because there can be only one (i.e. project references are not accounted for)
> Perhaps there should be a message box saying "references to '[identifier]' not found" or something like that, when no references are found for an identifier.
> Yup. When there's only 1 reference to an identifier, the feature jumps to that reference - if there's more than 1, it shows the toolwindow. If there's none, it does nothing... for now.
Use the where clause in a query to limit the records, don't use VBA function for that as it's going to be super inefficient — It's been a pleasure1 hour ago
> Following up on #442 - the feature currently behaves as follows:
- If only one reference is found for the target identifier, it automatically navigates to it. - If two or more references are found, the toolwindow is displayed. - **If no references are found, nothing happens**.
The last case is problematic. We need a message box saying something like:
> "No references were found for procedure 'DoSomething'."
Keeping in mind that "no references found" currently stands for "no re
> Rubberduck.1.22.Setup.x64.exe(2.86MB) - Downloaded 61 times. Last updated on 2015-04-01 Rubberduck.1.22.Setup.x86.exe(3.21MB) - Downloaded 133 times. Last updated on 2015-03-31
Procedure signatures are usually clearer when the parameters have an explicit type, and they're passed ByRef unless explicitly specified ByVal - so that procedure has two ByRef table As Variant parameters - i.e. it will happily take anything you throw at it. If you intend the procedure to work with ListObject objects, why not specify that in the signature? Or do you intend to work with strings? Then make it ByVal sourceTableName As String. Variants are VBA's ducks. Unless they're made of rubber, you should avoid them. — Mat's Mug3 mins ago
@Mat'sMug: Yes the procedure will work with list objects only I'm actually not an expert in VBA, I don't know how to specify in the signature? — Mahmoud Tarief3 mins ago
I'd say "click the [Fix] button" but that'd be over-the-top smapping
VBA Rubberducking
VBA Rubberducking