Like @jesse said you can have a custom method, maybe pass a user object to that method.
Something like this:
class User
{
public int AutoLoginRequestTemplate { get; set; }
public string username { get; set; }
public string password { get; set; }
public string Val1 { get; set; }
...
you have a lot of if statements in your SQL, this screams at me that you are doing something in your SQL that should be done in the application, and that this SQL should be separated into two distinct stored procedures.
the benefits
faster stored procedures
use an actual coding language to d...
These dependencies can't be fixed by naming. They are a symptom of some fundamental design problems. If you're having trouble finding methods, that's
a symptom of an overly coupled design.
You have a class names that really sound like methods in a completely different class.
Without knowing m...
You are correct in suspecting that the try/catch is not necessary. Generally speaking, Caesar ciphers are implemented using modular arithmetic. We can determine if a character is alphabetical by simply checking if alphabet contains that character; anything else (whitespace, digits, punctuation, e...
Regarding the problem selecting the right image type, you have enough information in your header to select which type of image to create.
case header of
Nothing -> putStrLn $ source ++ ": Bad image"
Just (header,_) -> case (imageEncoding header) of
ASCII -> putStrLn $ source ++ "...
Increase DRYness. Something like this:
var makeAnchor = function(prefix, suffix) {
return "#" + prefix + suffix;
}
var nflPrefix = "nfl-";
if ($(".userLocation").length > 0) { nflPrefix = "nfl"; }
$('header').attr("href", makeAnchor(nflPrefix, "city");
The ternary operator may be suitabl...
As far as I can tell, this code seems pretty easy to follow, especially with the comments. Here are several things that stood out to me:
Since you haven't provided your own queue implementation, I assume you're using std::queue. If so, remove using namespace std and use std:: where necessary....
Many beta-sites suffer with a problem of voting. Code Review is one of them. We at Code Review have realized that it is hard to vote for answers that you're not aware of, therefore some of us (no monkeys named) posts a link to a recent answer every now and then in the chat.
Instead of us posting...
Regarding the problem selecting the right image type, you have enough information in your header to select which type of image to create.
case header of
Nothing -> putStrLn $ source ++ ": Bad image"
Just (header,_) -> case (imageEncoding header) of
ASCII -> putStrLn $ source ++ "...
Here's a solution that is fairly compact and fast for large lists, but returns the two disordered:
def pairUp(list1: List[A], list2: List[B]): List[(A, B)] = {
val g1 = list1.groupBy(_.serial).toList
val g2 = list2.groupBy(_.serial)
g1.flatMap{ case (k,as) => g2.get(k).toList.flatMap(as zi...
This is a great first attempt with a consistent coding style and good variable names. Bravo!
Consider implementing the java.util.List interface so you could use it with existing methods. You already have most of the methods and would just need to change some names. For example, addEnd becomes a...
You can actually change the performance to O(n) by changing one line of code here (and adding a couple of imports):
import java.util.Set;
import java.util.HashSet;
...
private Set<String> listTempName = new HashSet<>();
Although this works, we can simplify the code a little bit. Effectively,...
First things first: You have a navigation but refuse to use anchor tags. Why? This is potentially harmful. How are you going to navigate if you don't have links? The only possible way would be completely relying on JavaScript. All users with disabled JavaScript have a useless list of words instea...
import os,glob
def findResults(directory = "/"):
results = []
for d in filter(os.path.isdir,os.listdir(directory)):
results.extend([os.path.join(directory,"testResults",fname) for fname in glob.glob(os.path.join(directory,"testResults","*.xml")] if d == "testResults" else findRes...
I'm afraid your code is very hard to understand. Part of the problem is your variable naming: I'm not sure what exactly p_x is and what distinguishes it from the x that's part of the Map object, for example. It also doesn't help that your comments mostly just describe the behaviour of entirely ...
Unless I'm misinterpreting your code, you should be able to get by with something like this:
def spec_context
directories = spec_repo.select { |path| File.directory?(path) }
files = directories.map do |dir|
spec_type.map { |type| Dir["#{dir}/**/*.#{type}"].sort }
end
files.flatten.un...
What you did well on:
Your program is easy to read.
You are allocating memory, even though it is unsafe in certain cases (other answers have addressed this, so I won't cover it).
You prepare for some corner cases.
Things you could improve:
You are returning 0 when your program runs into a...
A few notes (with efficiency aside, as you said):
Your defined ABS surrounded by parenthesis is not the usual way that C programmers declare macros so that they aren't problematic.
#define ABS(a) do { typeof (a) _a = (a); _a > 0 ? _a : -_a; } while(0)
Why are all of your single letter variabl...
I see no problems with it. However, at the HTML section, try adding maybe 2 lines of blank space in between the all of the divs. An example lies below.
<div id="pagecenter">
</div>
<div id="footer">
<div id="footercontent">
<div id="footerbanner">
</div>
</div>
</div>
</body>
<...
