Unfortunately, the CI tests in test_globalvars.py don't even attempt to do any testing of that portion of the code, or really anything in globalvars.py.
@ThomasWard Ahhh... IME, that's filling out forms and spending (relatively small) amounts of money. .... And later getting lots of advertisements sent to you.
@Makyen I think the config parser change worked perfectly, I don't see any explosions in the current Smokey config, nor anything odd in the logs on my end
@SmokeDetector Multiple identical answers linking to their gist, without clear disclosure. User has deleted 2 of the answers upon being told not to do that.
@SmokeDetector Author of the page is "Nicolas.liozeau" - Not quite "Nichola" so I'm not 100% confident this is undisclosed affiliation. User also has other contributions across the network. FP for now, imo.
[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, body starts with title and ends in url, link at end of body, potentially bad keyword in body (389): Charlie Stayt CBD Gummies by WilliamSotoa on askubuntu.com (@Ollie)
@SmokeDetector While there is an annoying amount of repeated characters, there's enough other content in this edit such that I wouldn't want it blocked.
@CodyGray The regex contains an unescaped ".", which should be "\." in most cases. Append -force to the command if you really want to add this pattern.
[ SmokeDetector | MS ] Bad keyword in body, blacklisted website in body, body starts with title and ends in url, pattern-matching website in body, potentially bad ip for hostname in body (388): We can really see these progressions by Martin Guptil on stackoverflow.com
[ SmokeDetector | MS ] Bad keyword in body, bad keyword in title, pattern-matching product name in body, pattern-matching product name in title, potentially bad keyword in body, +1 more (393): Green Canyon CBD Oil Reviews by AlanThur on apple.SE
@Makyen That pattern looks like it's already caught by Potentially bad keyword in answer and Potentially bad keyword in body Append -force to the command if you really want to add this pattern.
@Vega I'm not going to find out. That whole answer is better deleted. There is no reason to have that link, the sourceforge one is dodgy enough but at least that is in the accepted answer as well so I guess that is ok-ish
[ SmokeDetector | MS ] Few unique characters in body, no whitespace in body, no whitespace in title, repeating characters in body (328): g4564543345435345345345345345345 by Денис on ru.stackoverflow.com (@VictorVosMottor)
@ThomasWard One of my concerns is that having a strict time-limited cache will result in some performance degradation. However, what the extent of that is is probably not something which we will be able to determine, unless it's extreme, or through looking at a longer-term trend in scan rate.
It really should primarily be a concern for domains which are seen very commonly, or if there are common things which SD thinks might be domains, but aren't (e.g. "... end of sentence.Talk to ...").
