[ SmokeDetector | MS ] URL-only title, bad NS for domain in body, bad NS for domain in title, blacklisted website in body, blacklisted website in title, +5 more: freesupplementrial.com/alpha-trt/ by mrri on askubuntu.com (@Zoe)
[ SmokeDetector | MS ] URL in title, bad NS for domain in body, bad NS for domain in title, blacklisted website in body, blacklisted website in title, +4 more: freesupplementrial.com/alpha-trt/ by mrri on apple.SE
@AshishAhuja I opened the file and started looking at it but decided to not do that right now so yes please, if you have the time
the existing JSON file should probably be scrapped in favor of something else, there's about half a dozen active notifications which need to be ported over
the code which implements notifications is in Notifications.py predictably
@tripleee sure! I'll try to do it if I get time! Also, I just realised that PulseMonitor isn't running on the latest commit. Is there a problem with the code?
@tripleee I'm currently working on another project too, I'll try to have a look at PulseMonitor tomorrow; I'll ping you if I start making changes so that our work doesn't overlap!
upgrading both parts in tandem would probably be useful, there is currently no easy way to get the JSON file out of the Docker instance (though it would also not be technically very hard) so it needs to be done manually or otherwise handled explicitly
@tripleee Yeah, it has significant FP (~17% in all MS, but 50% in the time it's been active as a watch). OTOH, it's been the only detection of some recent TPs and added a detection reason on some other TPs. That it detects some things we're missing is a major reason for it being watched (19% of the matches in MS are manually reported posts). I'll be taking a look at how it might be adjusted to reduce FP, while still detecting those we're otherwise missing.
> Pattern-matching website in body, pattern-matching website in title ---------- Title - Position 10-22: inchennai.in Body - Position 10-22: inchennai.in
@tripleee Which parts? The JSON file will be automatically uploaded to Redunda along with other Botpy files (at least according to what I recollect from the changes I made), so what exactly are you talking about?
@AshishAhuja my idea was to replace the underlying system and then rebuild notifications on top of that ... there's an outline of this idea in the ticket but it's not much more complex than this
I'm planning to introduce a new thing beside the current notification system, which would allow people to see reports matching specific regexes through a command when they want to. If they want to be pinged, that's their wish.
> Pattern-matching website in body, pattern-matching website in title ---------- Title - Position 5-30: customerservicenumbers.co Body - Position 5-30: customerservicenumbers.co
@Zoe That pattern looks like it's already caught by Pattern-matching website in body and Pattern-matching website in answer; append -force if you really want to do that.
@Zoe Added 1800customerservicenumbers.com to watchlist
[ SmokeDetector | MS ] Bad NS for domain in body, bad pattern in URL body, blacklisted website in body, link at end of body, pattern-matching website in body, +2 more: Thermo Burn best diet by user828199 on askubuntu.com (@Zoe)
@AshishAhuja hmmm, the ticket suggests extending notifications so that we get other tags besides @ping added to matching lines; then the tag you request can be @ping easily
the current JSON file slightly stupidly collects the numeric user IDs of people who have requested notifications so that won't work for the reimplementation
being able to track who requested what would still be useful, and perhaps the JSON format could be extended with an optional tag and fall back to a ping if it's not there ... but this is pretty obscure
Here's what I think on the implementation: I'll create a new class beside the notifications class. I don't see why you want to include the notifications class with this. People can add tags to be shown with the reports when the tag's specified regex is met. Now, this tagging feature will be implemented in a separate class from notifications, and is going to be completely independent. The only place where it will relate with the reports is when PM is posting a HF message, where it will...
@tripleee But, in the future if we want to add another thing, the notifications class will be huge, and would be handling things not related to notifications.
@tripleee I don't know. I'm pretty sure we wouldn't have thought of the tagging idea when the notifications were being implemented; I always prefer keeping the code bits independent based on their function.
$ host asha24.com
asha24.com has address 13.57.139.100
asha24.com mail is handled by 0 mail.asha24.com.
tripleee$ host 13.57.139.100
100.139.57.13.in-addr.arpa domain name pointer ec2-13-57-139-100.us-west-1.compute.amazonaws.com.
@tripleee That pattern looks like it's already caught by Blacklisted website in body and Blacklisted website in answer; append -force if you really want to do that.
@tripleee That pattern looks like it's already caught by Potentially bad ns for domain in answer and Potentially bad ns for domain in body; append -force if you really want to do that.
@Glorfindel That pattern looks like it's already caught by Potentially bad keyword in answer and Potentially bad keyword in body; append -force if you really want to do that.
@tripleee That pattern looks like it's already caught by Bad keyword in body, Bad keyword in answer, Pattern-matching website in answer, and Pattern-matching website in body; append -force if you really want to do that.
@tripleee That pattern looks like it's already caught by Bad ns for domain in body and Bad ns for domain in answer; append -force if you really want to do that.
@quartata I started writing a Teams post about how domain tagging works but I discovered that I actually already wrote one, back in March: stackoverflow.com/c/charcoal/questions/256
anyone here with swift/xcode experience who can verify if the comment left as answer stackoverflow.com/a/50270054/578411 has merit enough to either edit or comment the OP of the other answer?
It looks like dll seems a legit name for them, even in an apple context.
I don't think the answer is technically incorrect, just terminologically sloppy (using a Windows term where I guess a more general term would be correct)
[ SmokeDetector | MS ] URL-only title, bad keyword in body, bad keyword in title, blacklisted website in body, blacklisted website in title, +1 more: mumybear.com/purefit-keto/ by user828235 on askubuntu.com (@Zoe)
[ SmokeDetector | MS ] Bad NS for domain in body, bad keyword in body, blacklisted website in body, link at end of body, pattern-matching website in body: A side effect to test out for all by hizvxww on askubuntu.com (@Zoe)
@Glorfindel That pattern looks like it's already caught by Potentially bad keyword in answer and Potentially bad keyword in body; append -force if you really want to do that.
[ SmokeDetector | MS ] URL in title, bad keyword in body, bad keyword in title, blacklisted website in body, blacklisted website in title, +1 more: ozfacts.com/rapid-tone-diet by nkos on apple.SE
