Charcoal HQ

11:02 PM

Anyone want to point me where the !!/report calls actually are parsed into the respective bits that're passed into the report() command call?

it's changed since I fussed with chat message parsing ;)

quartata

github.com/Charcoal-SE/SmokeDetector/blob/master/…

!!/report is a monadic ("1 argument") command. so it's passed "<url 1> <url 2> ..." and splits that separately

Thomas Ward

@quartata ahhhh, I think I see it there, I'm going to spin TCOM and call a bogus report command that'll break right after the report function is called to make sure that's what is seen, at least so I can make sure it's what I think it is. And to see what a " in there ends up as :P

so there'll be a single post that will never make it to smokey (yay HARDCRASH TIME!)

quartata

> An interesting thing to note about how the arity works is that normally the functions are assumed to be separated by spaces. If the maximum arity is greater than 1, it will split them by spaces (1 2 3 -> [1, 2, 3]) and take those as the arguments. If the maximum arity is 1 or less, however, it will take everything after the command to be one big argument (!!/cmd 1 2 3 -> cmd("1 2 3")). Most varity (as many arguments as you like) commands such as !!/report are actually 1-arity commands that then parse the URLs themselves.

(from stackoverflow.com/c/charcoal/questions/58/59#59)

Thomas Ward

so then with respect to !!/report, then, it passes everything as "1 2 3 4 5 6 7 8 9 10..." as a straight string?

quartata

mmhmm

Thomas Ward

11:06 PM

just want to make sure before I start fussing with things :p

cool, then I can just replace 'urls' with 'args' and then populate 'reports' like my proposed implementations would do. Assuming, of course, these changes are a desired command.

quartata

that's as opposed to something like this:

@command(int, int)
def add(x, y):
    return str(x + y)

Thomas Ward

right.

quartata

since that's dyadic at minimum it splits it and puts in x, y separately

Thomas Ward

OK, that makes sense, and reduces the 'tuples' approach to just parsing URLs and then finally a singular reason out, and when passing the reason in, "reason" is taken into account in constructing why_reason.

yay for less complexity :P

quartata

github.com/Charcoal-SE/SmokeDetector/blob/master/…

@ThomasWard i tried really hard

Thomas Ward

11:08 PM

eww that's evil. Yeah, I'll just parse inside the report function :p

quartata

well that's what it's doing behind the scenes is what I meant

Thomas Ward

still loading up TCOM to get a local test. I wonder if it doesn't like my computer's runtime, but if it'll like a 'clean' environment...

yep

quartata

you're the max_arity == 1 case

so it passes in args directly

which is just this: github.com/Charcoal-SE/SmokeDetector/blob/master/…

Thomas Ward

indeed. I'm still wanting to see what the actual things are in a report. TCOM won't even send it to MS, it hardfails right before, because I am EVIL that way. (yay for local trees!)

quartata

yeah I don't actually know what the URLs look like tbh

I think they have the https:// in front of them

Thomas Ward

11:12 PM

yay for pythonic forcekill?

quartata

...actually

I don't think they have the protocol

Thomas Ward

@quartata true, but the URLs are split out during the function call

quartata

since I think the href is gone, it's just the link text

Thomas Ward

i'm more curious if it's a pure string or not.

quartata

oh yeah it is

Thomas Ward

11:12 PM

and how it sees quotes

because that's the second part of it

if it's pure " chars then yay, if not then I have to mess with stuff in the logic I already wrote

stupid python3 taking too much time to install pip

once I get this thing set up I'll spin TCOM up and bogusreport. Then failover Solar Flare again

!!/location

SmokeDetector

@ThomasWard teward/Solar Flare

Thomas Ward

so yay for "BREAK IT!" and then restoring the good versions :P

Grant Garrison

Anything exciting happen?

Thomas Ward

hence the "dev on prod" tag

Byte Commander

Thomas is breaking stuff

Thomas Ward

11:14 PM

@GrantGarrison no but we're going to have a MS Failover Test Case shortly to see whether MS explodes :P

laughs evilly as darkness descends

Grant Garrison

That sounds well... evil

Thomas Ward

... i forgot how many recursive dependencies we have for Smokey... o.O

@quartata stupid question, but I thought we had tldas a end-user level requirement, not a system-wide tld requirement, hence the user_requirements.txt file

why's tld in the main reqs too?

quartata

...it shouldn't be?

Thomas Ward

it is

last line of requirements.txt in master and deploy

as well as the only user_requirements.txt req.

quartata

Art did it

github.com/Charcoal-SE/SmokeDetector/commit/…

~~kill him~~

Thomas Ward

11:17 PM

right but

quartata

you're right it should not be there

Thomas Ward

@ArtOfCode ^ why? We had all agreed that tld is a user-level requirement hence the user_requirements.txt item.

quartata

it causes weird permissions problems

Thomas Ward

if you have a reason i'll be glad to hear it

otherwise when I make a branch to implement custom reports, I'll include the fix in there

and then laugh even more evilly

Grant Garrison

@quartata !!/blame

!!/blame

SmokeDetector

11:19 PM

@GrantGarrison It's Makyen's fault.

@GrantGarrison It's Byte Commander's fault.

Thomas Ward

!!/standby teward/Solar Flare

SmokeDetector

teward/Solar Flare is switching to standby (@quartata)

Restart: API quota is 19999.

Thomas Ward

that's because TCOM is up :P

!!/location

SmokeDetector

@ThomasWard The Call of Midnight

[ SmokeDetector ] SmokeDetector started in standby mode at rev 7577dfd (SmokeDetector: Auto watch of wrestle-mania34\.ca by doppelgreener --autopull) (running on teward/Solar Flare)

Grant Garrison

Smokey is broken!

!!/blame

SmokeDetector

11:20 PM

@GrantGarrison It's McNets's fault.

quartata

...?

Thomas Ward

@GrantGarrison no, it was restarting.

!!/report askubuntu.com/questions/956457/…

SmokeDetector

@ThomasWard I hit an error while trying to run that command; run !!/errorlogs for details.

Thomas Ward

yes I know you did

I forced you to >:D

and you are dead now.

quartata

press f to pay respects

Thomas Ward

11:21 PM

Solar Flare will be coming up shortly.

OK so it looks like it passed as a direct string.

now to test this again with a couple args. BECAUSE I AM WEIRD THAT WAY >:D

SmokeDetector

teward/Solar Flare received failover signal. (@quartata)

quartata

!!/unnotify-all

SmokeDetector

@quartata I will no longer ping you if I report a post anywhere.

quartata

thank

SmokeDetector

Restart: API quota is 9221.

Thomas Ward

11:22 PM

fun fact: this is how the message showed xD

Grant Garrison

@ThomasWard It is broken. It shouldn't have selected McNets. Instead, it should have said someone who spoke more recently.

Thomas Ward

@GrantGarrison want to know a secret?

TCOM is a fresh instance, that might just be because it had no 'who spoke' data

MSG: '<chatexchange.messages.Message object at 0x7f5fac0b5b00>'
URLS: 'https://askubuntu.com/questions/956457/how-do-i-set-up-an-ubuntu-server-to-be-th‌e-router-for-two-private-networks-on-my'

quartata

@ThomasWard we don't do that anymore

Grant Garrison

@ThomasWard That's counter intuitive.

Thomas Ward

@quartata then we discovered a bug :)

quartata

11:22 PM

I pick a random user in the room, regardless of activity

Thomas Ward

TCOM is coming back up though I need a multiurl test.

SmokeDetector

Restart: API quota is 19988.

Thomas Ward

!!/standby teward

SmokeDetector

[ SmokeDetector ] SmokeDetector started in standby mode at rev 7577dfd (SmokeDetector: Auto watch of wrestle-mania34\.ca by doppelgreener --autopull) (running on teward/Solar Flare)

Thomas Ward

(TCOM doesn't have my name in it lol)

quartata

11:23 PM

nice trick

Thomas Ward

!!/location

SmokeDetector

@ThomasWard The Call of Midnight

quartata

also technically if it committed any evil you'd have plausible deniability

Thomas Ward

!!/report askubuntu.com/questions/956457/… askubuntu.com/questions/34978/… "The Darkness Comes"

yep

SmokeDetector

@ThomasWard I hit an error while trying to run that command; run !!/errorlogs for details.

teward/Lunar Eclipse received failover signal. (@quartata)

quartata

11:24 PM

makes you think

!!/unnotify-all

SmokeDetector

@quartata I will no longer ping you if I report a post anywhere.

Thomas Ward

lol Lunar came up xD

Grant Garrison

@command(whole_msg=True)
def blame(msg):
    unlucky_victim = msg._client.get_user(random.choice(msg.room.get_current_user_ids()))

    return "It's [{}](chat.{}/users/{})'s fault.".format(unlucky_victim.name,
                                                                 msg._client.host,
                                                                 unlucky_victim.id)

SmokeDetector

Restart: API quota is 19999.

Thomas Ward

salts and burns TCOM because 'yay'

!!/location

SmokeDetector

11:25 PM

@ThomasWard teward/Lunar Eclipse

quartata

before it used to keep track of users chatting which I assumed predated get_current_user_ids

(probably did)

Thomas Ward

probably.

SmokeDetector

teward/Solar Flare received failover signal.

Thomas Ward

waits for Solar to failover again

quartata

so this is slightly different behavior in that regard since Smokey had to see them talk before

Thomas Ward

11:25 PM

!!/standby teward/Lunar Eclipse

SmokeDetector

teward/Lunar Eclipse is switching to standby

Restart: API quota is 9208.

[ SmokeDetector ] SmokeDetector started in standby mode at rev c0682c6 (SmokeDetector: Auto watch of reihmann\.de by K.Dᴀᴠɪs --autopull) (running on teward/Lunar Eclipse)

Thomas Ward

eesh maybe I should've let Lunar take over for a while o.O

quartata

but I wasn't going to bother keeping it either way since it would require storing per-room data and I try to cut down on that because it makes for some very ugly code

Thomas Ward

when does quota reset again?

quartata

@ThomasWard soon

Thomas Ward

11:26 PM

URLS: 'https://askubuntu.com/questions/956457/how-do-i-set-up-an-ubuntu-server-to-be-th‌e-router-for-two-private-networks-on-my askubuntu.com/questions/34978/…‌t-exist-suggest-installation "The Darkness Comes"'

yay, so it does only take a string.

my logic should work as-is, then, and it came in as a pure quotation mark too :D

quartata

you know what you could do

Thomas Ward

@Undo disregard any exploded Hair On Fire notes

quartata

have it take [(<url>, <reason>), ...] and use ast.literal_eval

Thomas Ward

was messing with the dev instance TCOM for the massive

@quartata true, I could, but we'd have to change the arity parameters then. And we still have to parse out quotes

quartata

nah man

I mean that it would literally be like

!!/report [("https://codegolf.stackexchange.com/questions/155018/the-programming-language-‌quiz-mark-ii-cops/155556#155556", "bad answer")]

sd poof

Thomas Ward

11:28 PM

laughs

Grant Garrison

@ThomasWard 31 minutes 18 seconds

quartata

I mean

it's not exactly good UX

but it would be easy and that's what counts right

Thomas Ward

@quartata true, that's an option, but TBH it's easier to accept url url url "Reason goes here" and split/parse in report(...) in the Python

quartata

sure, just have to handle the spaces in the reason names

Thomas Ward

@quartata if you review the logic I wrote, it does it in two phases

splits out the reason from the URLs list

then processes the URLs string into individual URLs, and loops over the URLs to issue the MS report calls

quartata

11:30 PM

but what if there are quotes in the reason name :P

that seems like something tripleee would do tbh

Thomas Ward

@quartata then it would fail to process either way, because it's not the accepted format that was proposed.

and we should then go find tripleee and hit them with a big stick

so before I go and write this logic into its own branch for consideration, we probably need to come up with an acceptable format for how we pass in a reason or not - the logic I wrote was based on the proposed new formats provided in the pull req

oops?

we could use url url url | reason for all I care, it just needs to be a uniform, decided-upon format that we can easily .split on.

so short of me hand-writing a customized 'split' mechanism to handle stupid cases where there's quotes that need to be included in the reason (why would someone use " quotes anyways...), we need to just decide on the final format to use for the command with the optional reason.

regardless there'd be a test to determine if the split args passed in with the specific string is greater than two, and if it is return a failure code, or attempt to concatenate splitargs[1:] with the 'split' character as the 'reason' variable. Which would work even if there's only one object in the 'set' that we're using in the .join call.

Catija

!!/scan judaism.stackexchange.com/a/91104/16629

SmokeDetector

@Catija Cannot find data for this post in the API. It may have already been deleted.

Thomas Ward

11:56 PM

hrm

@quartata want to take a look at the failing test(s) in my code commit and see what I'm missing?

maybe it doesn't like the new syntax... or wait maybe I botched it

oops my bad i fixed it

forgot urls is now a list, so we can't split it. We can however take the list of URLs and make a set of URLs to rule out dupes :D

quartata

yeah there you go

Thomas Ward

@Andy I have a question for you: how do we handle manual reports already?

@Andy the answer is we have a static string passed in for 'Manually reported by 'reporter' in 'room name'.'

quartata

we actually have some pretty decent unit tests for !!/report

feel free to add to them

Thomas Ward

@quartata check GH

i.e. "Wait...are we having these reasons as official MS reasons or just using
them to give to Smokey to provide context when it reposts the link
elsewhere?" which is what Andy just posted to GH as an email reply

quartata

that goes in the why

Thomas Ward

11:59 PM

@quartata right, but the question is whether that's relayed back in the chat message to rooms

and I don't believe it is

quartata

oh, yeah no it's not

Transcript for