« first day (2497 days earlier)      last day (1315 days later) » 

@thesecretmaster We would want to check if the report matched all of: link, title, body, username, and why text. If all of those match, then don't create a new record. Given that we might have more than one post record for the link where the title, body, username or why text changes, we still need the basic "is there more than one report for this link" check in autoflagging, so it's not just a move of the check.
 
And what should it return to smokey? Success?
 
3:06 PM
@SmokeDetector ignore-
 
@thesecretmaster It would be nice if there was a distinct response when there's a duplicate, but that's not necessary. SD could be able to do something with a distinct response (e.g. edit/delete chat reports/stop those that are queued), but if it's harder for MS to give such a response, or if the check should happen after the response is sent, then that's OK.
 
Wait... @double-beep how did you ignore feedback through FIRE?
 
@Makyen I can return a 200 instead of a 201?
 
3:08 PM
@thesecretmaster Sure. That sounds reasonable.
 
I've got no way to test locally since I don't have a SD instance, how do you feel about testing this on prod now?
 
I'll need to double check what SD does with the response, but we should be able to detect that.
 
Let me see what SD does with the response... one second.
 
[ SmokeDetector | MS ] Potentially bad keyword in body (1): Know about the Stack Exchange? by Parul Srivastava on meta.SE
 
@Spevacus it was done using the MS API key FIRE uses
 
@double-beep Ah. So... Magic.
 
tp feedback received on [MS] What are Salesforce ID's composed of?
fp feedback received on [MS] QGis 3.0 Multiuser Access
fp feedback received on [MS] Scrum vs. Sprint
 
3:13 PM
@Spevacus but probably I should get a new key
 
@Makyen can I have an MS API key?
 
@double-beep Note that doing that does not actually record an "ignore" with SmokeDetector. In other words, it is ineffective. And, yes, I've tested that.
 
fp feedback received on [MS] Please Help whit ALPS board
fp feedback received on [MS] Customer Notification
 
@double-beep Yes.
 
@Makyen good to know, thank you
 
@thesecretmaster Looks like SD will be fine with that.
 
Do we have an easy way to test this?
Like, can we make SD try and produce duplicate reports somehow?
 
@user12986714 Post 1: Looks like spam but not reported: Post is bumped by community ♦️
 
@user12986714 Post 1: This does not look like spam
 
3:22 PM
@thesecretmaster We can always do one or more !!/scan-force or !!/report-force, but, IIRC, the why potentially changes when that's done, so doing the -force twice might be needed.
 
Alright I'll go ahead and deploy these changes
 
It would probably be good to do the test from a test SD instance, rather than the main instance, so it doesn't report in chat everywhere. Let me spin up my test instance.
 
3:23 PM
Alright, I'm deploying the changes now
 
Should be live now
 
@thesecretmaster OK. My test instance is running here. I'm going to scan the most recently reported post.
 
3:34 PM
[ SmokeDetector | MS ] Potentially bad ns for domain in body (1): Set filedirectory in LaTex individually for each data type(csvsimple) by Syralia on tex.SE
 
@thesecretmaster It looks like the post records are still created.
 
[ SmokeDetector | MS ] Potentially bad keyword in answer (1): Because of which element the world has come together? ✏️ by Samana Johann on buddhism.SE
 
fp- feedback received
fp feedback received on [MS] Why is my text render so weird?
fp feedback received on [MS] indiex in google serp
tp feedback received on [MS] indiex in google serp
fp feedback received on [MS] Content Alignment on Site
fp feedback received on [MS] Vs1838B break beam problem
fp feedback received on [MS] How to make a port forward in Mac OS X
fp feedback received on [MS] Order posts by price
fp feedback received on [MS] How to do Factory Reset
fp feedback received on [MS] No sound with Thunderbird 12.0.1
fp feedback received on [MS] What are the 29 tenets of the Bishnois?
fp feedback received on [MS] Closed Loop Stability in MATLAB
 
3:53 PM
[ SmokeDetector | MS ] Potentially bad ns for domain in body (1): My wordpress site crashes when I login! by Mohamed Nawareg on wordpress.SE
 
[ SmokeDetector | MS ] Potentially bad keyword in body (1): How determine a trade in stock market is buying or selling by Evilangel on stackoverflow.com
 
3:59 PM
@Makyen Looks like deduplicating server-side works, although would it be better if I changed the text of the MS reply to be "Duplicate Report" or something? And then SD could make an edit if it receives that?
 
[ metasmoke-deploy ] deploy started by thesecretmaster
fp feedback received on [MS] Is fascism left or right wing?
 

« first day (2497 days earlier)      last day (1315 days later) »