@angussidney IMO, that's sub-optimal when under the belief that you have a public relations issue and/or are attempting to convince people that your point of view is good/the right way to proceed (i.e. 5 autoflags). The data should be represented truthfully, and if someone wants it, open/complete. But, this is just information that isn't relevant outside of development or a user fixing a problem with authorizations/usage, and can add confusion/ammunition for those biased against the project.

However, using "able"/"unable" makes it significantly better. It would be quite helpful if that terminology could be used throughout the site instead of "failures".

API quota rolled over with 11079 requests remaining. Current quota: 19999.

[ SmokeDetector | MS ] Bad keyword with a link in answer, link at end of answer, username similar to website in answer: What is the correct sentence: “Who are we?” or “Who we are?” by Panama Real Estate Brokers on ell.SE

Merged SmokeDetector #1672.

@Mithrandir A third system with spare cycles for a Smokey instance. Another server I recently got to supplement my other ones.

@SmokeDetector k

CI on 8592d31 succeeded. Message contains 'autopull', pulling...

[ SmokeDetector ] SmokeDetector started at rev 8592d31 (metasmoke: Merge pull request #1672 from Charcoal-SE/auto-blacklist-1520119560.3038592 --autopull) (running on teward/Solar Flare)

Restart: API quota is 19687.

@ArtOfCode I'm actually going to make a couple more changes to my dash. I have new ideas

How confident are we in the alibaba\W*cloud pattern? I'm getting a little push back on it and would like to be able to support the pattern or offer an alternative.

I'm also on mobile right now

@Andy pushback for what reasons?

@Andy pretty sure it was a CM that said to nuke them

@ArtOfCode can you give me a 5 second tutorial on how to work with Rails seeds

@quartata think about db/seeds.rb as if you're in a Rails console

done

oh

well ok

that's easy

yup

so it's really just a semantics thing

wrt keeping it in that file

yeah

it's just a file that rails db:seed points at

What's the link to the failed flag logs + why it failed?

@thesecretmaster metasmoke.erwaysoftware.com/flagging/logs?filter=failures

That hover thing is too hidden. I don't like it.

finally managed to clean up the fetcher

god is it complicated

as soon as I seed the database it might actually run

that would be nice

@quartata If you want nicer seeds, copy github.com/ArtOfCode-/SCOT/blob/master/db/seeds.rb and you can use YAML files as seeds

Rails.application.eager_load! ?

why would it be lazily loaded

Rails usually is

only time it's not is in prod, by default

so if you don't eager load there explicitly, you get missing constant errors

weird

naa by ArtOfCode on Skype two way screen sharing [MS]

@ArtOfCode If I signed up for autoflagging and pick a threshold, is the threshold that I pick public knowledge?

@thesecretmaster 50/50

It's not public in that it's not shown to anyone outside of admins, but I don't treat it like it's private info

What I want to do is create a tab where mods can easily see the autoflags that were cast on their site, and I was thinking about showing users+thresholds. I could also just make that bit mod-only.

[ metasmoke ] ci/circleci success on b15e5db: Your tests passed on CircleCI!

@thesecretmaster so... like a table with a row per flag, and the row lists the user+threshold it was cast under?

Like a list of users, thresholds, flags cast. "Autoflaggers on your site"

Uh

You can also tell me I'm crazy :P

Well, I don't have an issue with showing thresholds, they're not particularly sensitive info. I'm just not sure I understand what you're thinking of, but I guess that bit's up to you :P

so yeah, go ahead

A thought: thresholds might not be the right information to show

OK. I think it's be useful for mods to know who is signed up for autoflagging on their site.

I just don't know if that's full public, or mod only + ms admin.

A non-Charcoal mod coming along and seeing "Joe Bloggs, min weight=300" isn't going to be much use for them - they don't know what the weight means

@thesecretmaster Go with mod only for now, we can always change it

Might be better to display a list of users and their condition accuracies instead?

OK. I was thinking about converting "weight" to approximate % accuracy

That

@thesecretmaster No need to go approximate, we calculate the precise condition accuracy for validation already. Lemme add a thing to actually store it, and you can use that

OK

You can assume it'll be under flag_condition.accuracy

Users have many flag conditions?

yup

k

FlagLog belongs_to FlagCondition

OK.

@ArtOfCode that's a funny relation

not really

you have to have a valid flag condition to be able to cast a flag

so we record which one that is

You can only have one flag_condition per site, right?

this will be so powerful once we have a frontend:

PostType.create(:name => 'questions', :ws => 'questions-active', :route => '/questions', :allocation => 7000)
PostType.create(:name => 'comments', :ws => nil, :route => '/comments', :allocation => 3000)

imagine being able to adjust how we consume the quota or even add completely new post types without code

take a moment to savor the pipe dream

anddddd stop

@thesecretmaster You can have more than one; all have to satisfy the conditions.

Aw

Makes my life harder, but shrug

I wouldn't give mods that kind of information, honestly. It's low level enough that they don't need it.

OK. I'll skip it, it would be a pain anyways

Wanna help me with an AR query?

Sure!

Here's the query: User.joins(:flag_logs).where(flag_logs: {site: @site, success: true, is_auto: true}).group(:user_id) I want this query, ordered by number of successful autoflags

Riiiight

I can't seem to sort out how to do it, because it's ordering by count of a relation

There's a way to do this, I have to look it up every time

All righty I've recreated all the migrations and I think I'm good to go

Now for the most critical question

How do I actually get Rails to make the database...

:P

rails db:create ?

bundle exec rake db:create

that won't seed though right

I have to do that separately

ProTip: Rails, not rake, after 5.x. They're deprecating the rake versions at some point IIRC

really?

yeah I'm using bin/rails

rails db:create; rails db:migrate; rails db:seed

@thesecretmaster blog.bigbinary.com/2016/01/14/…

...huh

so I'm confused

@Undo so order('COUNT(flag_logs.user_id)')? Because that doesn't work.

the devise migration throws an error

ah

I see why

What's the error?

it does an ALTER TABLE

@thesecretmaster Doesn't work how?

because it assumes you already have a users table

just need to change it to a CREATE TABLE (it's the first migration)

yay

@Undo Doesn't do what I want it to do -- I want to order by sucessful auto flag_logs

ok

here we go

@thesecretmaster order('COUNT(flag_logs.id) DESC') instead

Aha! Thank you

Wait.. I think that's still including failed flags

@ArtOfCode Maybe success/error?

@thesecretmaster What's your full query now?

User.joins(:flag_logs).where(flag_logs: {site: @site, success: true, is_auto: true}).group(:user_id).order('COUNT(flag_logs.id) DESC')

Have the generated SQL handy?

That should work

Yeah

@thesecretmaster don't do that, either, migrations from the start will break

rails db:create followed by rails db:schema:load

Yeah, but I don't think @quart has a schema yet

Yeah it hadn't been generated yet

...huh

so Ruby doesn't like this:

ah, thought we were talking about metasmoke

> items = items[:-1]

I didn't know about that

@Undo SELECT `users`.* FROM `users` INNER JOIN `flag_logs` ON `flag_logs`.`user_id` = `users`.`id` WHERE `flag_logs`.`site_id` = 1 AND `flag_logs`.`success` = TRUE AND `flag_logs`.`is_auto` = TRUE GROUP BY `user_id` ORDER BY COUNT(flag_logs.id) DESC LIMIT 11

I guess I can use chop though

@quartata What does that do?

@thesecretmaster everything but the last

Ah, I usually would do that with [0..-1]

Didn't know that would work

oh I got the wrong slice syntax then :P

it's a Python thing

Yeah... that throws an error in ruby

something more interesting

even though my init code comes after Bundler.require(*Rails.groups) in config/application.rb, redis isn't imported...

@thesecretmaster Sure that's not working? It sure should.

@thesecretmaster User.joins(:flag_logs).where(flag_logs: {site: @site, success: true, is_auto: true}).group(Arel.sql('users.id')).order(Arel.sql('COUNT(flag_logs.id) DESC')) works for me

...maybe that's because I forgot to make an instance of it

ok I think this is the one time when using a global variable is correct

It's sorta working. I think it's sorting by all flag logs, not sucessful auto flag logs

hmmm

stackoverflow.com/questions/16996618/… does say to use left_joins instead of joins

Maybe try that?

actually I could just stick it in Inferno::

@Undo that'll just have the effect of including users with 0 flags

[ SmokeDetector | MS ] Few unique characters in body, no whitespace in body: てすとてすとてすと by awwa500 on ja.stackoverflow.com

@ArtOfCode Oh, right. So it shouldn't matter.

@Undo shouldn't, no. It's working for me

and it's also definitely returning the right thing

holy shit it's running

time for the true test

sd k

@ArtOfCode Not sure if you saw it earlier, but it turns out we made a colorblind nuclear bomb with that grid thing

Needs to be better, somehow.

...well

@Undo aye, saw. Need to find some colors that work... I'd kinda like to keep green for TPs

I hadn't thought of that at all

since Puma doesn't fork off any workers by default, the parent process ID is actually my shell

so the failsafe is stopping it from spawning any of my worker threads :P

Well, I'll just leave the query as is then

@ArtOfCode Maybe a light green and dark red would work?

Or the opposite

Grrr... I need my javascript back to test this change...

...

now when I tell it to spawn worker processes I'm not sure it runs my init at all

maybe it captures STDOUT?

[ metasmoke ] ci/circleci success on 2c4c4c0: Your tests passed on CircleCI!

Does MS use fontawesome?

o I forgot to add routes

hahahahaha

@thesecretmaster Think so, but I can't point to where off the top of my head

Maybe not, actually

if it's not in application layout then no

the Charcoal website does

MS is bootstrap

@Undo looks like it should do. Lemme see what I can do

[ SmokeDetector | MS ] Phone number detected in title: string "09488112635" to int arduino by Bear on stackoverflow.com

52	1	188.5769
52	2	84.7885
59	3	48.3220
62	4	22.1613
51	5	10.3333

That should be easier on colorblind eyes

@SmokeDetector f

@ArtOfCode Can we try a black background? Contrast is pretty high now between the green and the background

@Undo as in black gridlines?

Interesting. Looks like Rails::Server isn't defined when I run it from Puma directly?

Seems better to me, your thoughts?

@Undo yeah, likewise

@thesecretmaster site dash has broken something, I'm afraid

What something?

reports graph at the top on /graphs doesn't load

Grr

Looking now

Ah, I see. Lemme finish what I'm in the middle of, then I'll fix it.

[ SmokeDetector | MS ] Offensive answer detected: How do I move folders in MS Teams by user9440333 on stackoverflow.com

tpu by Jamal

[ SmokeDetector | MS ] Link at end of answer: marking Outlook mail item as read not working in C# code by Aman Deep on stackoverflow.com

naa by Jamal

naa- by ArtOfCode

@ArtOfCode Just created a PR with dash updates and a graph fix

[ metasmoke ] ci/circleci success on c4f2b33: Your tests passed on CircleCI!

[ metasmoke ] ci/circleci success on c4f2b33: Your tests passed on CircleCI!

Yup, graph fixed

Did you take the site icons out?

I just added two comments to the gist

no that's just my adblocker

well done adblock

[ metasmoke ] ci/circleci success on 55644ea: Your tests passed on CircleCI!

Can you tell when we started autoflagging?

@Undo Wanna deploy my changes?

I miss having javascript in dev

Reviewing

Is graphs_controller:19 going to work when params[:months] is nil? Looks like it needs an SNO or two

@Undo No error, but it's a bug

nil.to_i.months.ago || 3.months.ago returns DateTime.now

Ah, it's the same bug as I fixed for the reports graph

Deploying anyway, can fix later. Not critical.

@thesecretmaster (params[:months] || 3).to_i.months.ago

That

[ metasmoke ] ci/circleci success on 7fdf302: Your tests passed on CircleCI!

deploy finished

The annoying thing is that it take 3-10 seconds to load

@thesecretmaster you're missing an includes somewhere

Because it loads data for all the tabs

but it still loaded in 657ms for me

Reload

OH wow

It's faster on prod

That's nice

Often is

See, the order thing is broken

posts.autoflagged needs indexed

Fixed the bug and the missing include

@ArtOfCode You could copy that bug fix to a bunch of the graphs that I touched

Including #reports

I kinda want to make tab navigation JS

[ metasmoke ] ci/circleci success on 57bd92a: Your tests passed on CircleCI!

[ metasmoke ] ci/circleci failure on 0bfc741: Your tests failed on CircleCI

@SmokeDetector shush

I found some sort of bug, but I can't really tell where it comes from. The dash thinks that this post was autoflagged, but it wasn't.

No flag logs on that at all

Post.where(autoflagged: true, site_id: 344) returns post ID 74492

But if you look at that ID on MS, you get a SO post.

Failed log

Hmmm why the dash tells me to go away

There's a mod only tab

@thesecretmaster metasmoke.erwaysoftware.com/post/74492 is definitely a CSE post

Ah, I made a typo

@thesecretmaster hmm ok I see

[ SmokeDetector | MS ] Bad keyword in title, potentially bad keyword in body, potentially bad keyword in title: Leading Desert Safari Dubai Tour Company for International Tourists visiting Dubai, UAE by Desert Safari on superuser.com

tpu- by K.Dᴀᴠɪs

@Undo I thought I was avoiding those when I asked for autoflagged:true?

Looks like it should be. Maybe the retroactive migration goofed.

I'm gonna announce it in the TL now though, and ask for feedback

[ SmokeDetector | MS ] Bad keyword in body, blacklisted website in body, link at end of body: Immune Turmeric The problem is that your body by foshingn12 on askubuntu.com

so @thesecretmaster I found your user ordering bug

tpu- by K.Dᴀᴠɪs

You're ordering them by the count of successful autoflags on the current site

What'd I do this time?

You're displaying total successful autoflags for that user

not site-scoped

Ohhhh

I want it site scoped

I see

Yeah. I'm gonna see if I can optimize that query, because it's currently doing two separate queries for every user, which is... sub-optimal

You wanna fix it, or should I? I can't push to master

OK. Thanks

While you're at it, the reason pie chart looks implausible for CSE

Grr

I'll look at that

Looks like it's just not site scoped; simple fix.

Yeah, just saw it

params[:site_id] instead of 1

@ArtOfCode ^^

Also, design thought: Can we make the 'reports' and 'time to deletion' graphs align vertically? Would be neat to be able to xref those two graphs.

What could that comparison give us?

They're on the same scale, just different widths. My brain wants to be able to see them stacked vertically and see how post volume affects TTD.

hey can I get someone else with rails to reproduce something

Low priority.

@quartata Maybe

can you make a new rails app and put this in config/application.rb

I intentionally spaced them out because I want the reasons graph to be more readible.

Woops

@thesecretmaster I was more thinking artificially expand the tp/fp pie chart.

It won't expand unless you give it more vertical space

if defined?(Rails::Server) then puts "hi" end

@thesecretmaster You can't just put it in a col-md-5?

You can, but the pie won't get any bigger

Don't care about the pie being bigger; care about the reports and TTD graphs being on top of eachother

Oh, then that'll work

I was trying to take advantage of the space the pie was taking up that it didn't need

Yeah, it's a good thought.

You could put both ttd and reports on the same graph, with 2 y axis

If chartkick lets you

@quartata Then what?

@thesecretmaster Worth a try; might overload that chart visually. Don't know.

@Undo first try starting with bin/rails s, then with bundle exec puma

I'm gotta run now, but I don't care too much either way. If you want them stacked, stack em. Bonus points if you can make chartkick have 2 y axis

you can, but it's a pain

[ SmokeDetector | MS ] Bad keyword in link text in answer: Limited FaceBook friends show up in Contacts app in Mavericks or Yosemite by Tim on apple.SE

Also, before I go, I'm noticing that MS is missing deletion data for quite a few posts.

@quartata Get a hi out of the first, not the second

@thesecretmaster Historically, yes.

@Undo that is so annoying

Didn't you fix that with Shogs data?

@Undo is application.rb being run at all? Put another puts outside the if?

@thesecretmaster Verified that the data we have is right. I can't just import that data because some of it points to the last deletion, not the first.

@quartata It's definitely run.

Makes no sense

I mean ... if you keep a csv of which ones you imported data for, the late data is better than no data.

Agree, will try to look at it some time.

It's lower priority knowing that the data we do have is good.

Gotta run, maybe until morning.

[ SmokeDetector | MS ] Bad keyword in answer: Split audio file with cue file by Helen D on superuser.com

fp- by K.Dᴀᴠɪs

[ SmokeDetector | MS ] URL-only title, bad keyword in body, bad keyword in title, blacklisted website in body, blacklisted website in title, +4 more: buysupplementsreview.com/invigorate-x/ by user801911 on askubuntu.com

tpu- by K.Dᴀᴠɪs

@thesecretmaster Please define TP and FP somewhere on the dashboard. You're about to ask a bunch of people who don't normally live in the MS world to look at the page, but are repeatedly using acronyms which they may not understand.

@Makyen done

@thesecretmaster Please add titles/captions to the pie charts. Right now it's not clear what they mean.

@ArtOfCode ty

[ metasmoke ] ci/circleci failure on b9c8c10: Your tests failed on CircleCI

[ metasmoke ] ci/circleci failure on af5917d: Your tests failed on CircleCI

The use of the "spammers" tab is unclear. While it appears the "Not a spammer" links to a mod-only location (OK, but better to not show them as a link for those who are not privileged), every single page of spammers that I've looked at shows Post Count = 0, which I consider unlikely to be intended.

@Makyen also done

@Makyen yeah, we don't track post count, so that's always zero

@ArtOfCode Then there's no reason to show it.

aye, I removed it

Organizationally, it really feels that "All Time Summary and Posts" should be at the top as a summary of the page. Leading into the page with just a bunch of text feels unfinished. Maybe that portion just needs a heading.

[ metasmoke ] ci/circleci success on 99241b5: Your tests passed on CircleCI!

[ metasmoke ] ci/circleci success on 6f9d300: Your tests passed on CircleCI!

Suggest: change "Posts Caught:" to "Posts Identified" (or something similar).

Heading done, bug fixed

Cool.

[ metasmoke ] ci/circleci success on 7d254fd: Your tests passed on CircleCI!

[ metasmoke ] ci/circleci success on b88a3f5: Your tests passed on CircleCI!

Hmmm... Actually, given that there's a graph labeled "Reports", "Posts Caught:" should be just "Reports" to match the graph.

[ metasmoke ] ci/circleci success on dbb17c2: Your tests passed on CircleCI!

[ metasmoke ] ci/circleci success on d77ed14: Your tests passed on CircleCI!

Ahhh, OK. "All Time Summary and Posts" is a heading including the tabs. Perhaps some more space between that heading and the graphs to more clearly separate it as a new section that includes everything below it. Actually, what would probably make it significantly more clear is to have a similar centered heading above the text at the top that states the top section is about the user-selected time period. Having that would make it much more clear that there are two separate sections.

Hmmm... it looks like the rest of the site uses left-justified headings. I'd suggest changing "All Time Summary and Posts" to be left justified to match the rest of the site. That may have contributed to my thinking the heading only applied to the table immediately underneath it.

Nit: The thousands separator is used inconsistently in the page: The text uses none. The graphs use a space.

The time to deletion graph: Use less precision on the numbers displayed. Technically, it's unclear what precision actually exists. From a user perspective, they have no need to have more than one or two digits past the decimal place.

Overall, I think it looks really good.

[ SmokeDetector | MS ] Bad keyword in body, blacklisted website in body, link at end of body, pattern-matching website in body: Es wird sich um Ihre Bestätigungsstruktur kümmern by Sualind1987 on askubuntu.com

tpu- by K.Dᴀᴠɪs

[ SmokeDetector | MS ] Bad keyword in body, blacklisted website in body, link at end of body, pattern-matching website in body, repeated URL at end of long post: Sparen Sie Ihre wichtige Zeit und Geld für kostspielige by Hungs19 Virk on superuser.com

tpu- by K.Dᴀᴠɪs

[ SmokeDetector | MS ] Bad keyword in body, blacklisted website in body, pattern-matching website in body, repeated URL at end of long post: Die meisten Artikel erwarten von Ihnen, by Hungs19 Virk on graphicdesign.SE

tpu- by K.Dᴀᴠɪs

[ SmokeDetector | MS ] Bad keyword in answer, blacklisted user: TeraCopy does not start copying automatically by George Renee on superuser.com

Restart: API quota is 17966.

tpu- by DavidPostill on Getting ROBOCOPY to return a "proper" exit code? [MS]

Conflicting feedback on Getting ROBOCOPY to return a "proper" exit code?.

fp feedback on autoflagged post: Getting ROBOCOPY to return a "proper" exit code? MS (@Floern @iBug @DraconicPenguin)

Conflicting feedback on Getting ROBOCOPY to return a "proper" exit code?.

[ SmokeDetector | MS ] Bad keyword in body, blacklisted website in body, link at end of body, pattern-matching website in body, repeated URL at end of long post: Es gibt keine unzweifelhafte Motivation zu by Tord lymp on drupal.SE

tpu- by K.Dᴀᴠɪs

tpu- by K.Dᴀᴠɪs on TeraCopy does not start copying automatically [MS]

[ SmokeDetector | MS ] URL-only title, blacklisted website in body, blacklisted website in title, link at end of body, pattern-matching website in body, +4 more: infosupplement.com/vandexafil-ultra by Tion Glni on askubuntu.com

tpu- by K.Dᴀᴠɪs

@thesecretmaster for reference, this is what it looks like on my 21:9 1080p monitor:

Also, notice how the 'posted at' information is duplicated

Project Links: Blaze (GH) | SmokeDetector (GH/wiki) | metasmoke (GH/API) | Userscripts (GH) | Meta: Who to ping | Channel

[ SmokeDetector | MS ] Bad NS for domain in body, blacklisted website in body, link at end of body, pattern-matching website in body, potentially bad keyword in body, +1 more: on the professional nitronemax web site by Ruis lymp on drupal.SE

tpu- by K.Dᴀᴠɪs

@SmokeDetector fp

@Makyen Registered answer as false positive and removed user from the blacklist.

Conflicting feedback on Getting ROBOCOPY to return a "proper" exit code?.

[ SmokeDetector | MS ] URL-only title, bad NS for domain in body, bad NS for domain in title, blacklisted website in body, blacklisted website in title, +6 more: top10sideeffects.com/nitronemax/ by Herl1949 on askubuntu.com

tpu- by K.Dᴀᴠɪs

[ SmokeDetector | MS ] Bad NS for domain in body, bad NS for domain in title: upsiteworth.com/ --> How to fix “page trying to load scripts from unauthenticated source by Haroon Ashraf on stackoverflow.com

fp- by DavidPostill

fp feedback on autoflagged post: https://upsiteworth.com/ --> How to fix “page trying to load scripts from unauthenticated source MS (@Glorfindel @Cerbrus @River)

[ SmokeDetector | MS ] URL in title, bad keyword in body, blacklisted website in body, blacklisted website in title, pattern-matching website in body, +4 more: infosupplement.com/vandexafil-ultra by Tion Glni on apple.SE

tpu- by K.Dᴀᴠɪs

fp by angussidney on Limited FaceBook friends show up in Contacts app in Mavericks or Yosemite [MS]

[ SmokeDetector | MS ] Bad NS for domain in body, blacklisted website in body, link at end of body, pattern-matching website in body, potentially bad keyword in body, +2 more: I as soon as in a blue moon loved it and might returned every person for use! nitronemax pros? by Busly19 Virk on superuser.com

tpu- by K.Dᴀᴠɪs

[ SmokeDetector ] Bad NS for domain in body, blacklisted website in body, pattern-matching website in body, potentially bad keyword in body, repeated URL at end of long post: offers past doubt a hundred% help includes innate elements increases fury and doggedness by Busly19 Virk on graphicdesign.SE

tpu- by K.Dᴀᴠɪs

[ SmokeDetector | MS ] Repeating words in title: This is a test Test Test Test Test Test Test by Kang Chang on stackoverflow.com

tpu- by Makyen