Charcoal HQ

@angussidney I think so yeah

KeyError: question_id

I'll need to take a look at the API response

A few ideas for other random refactors: post/postdata consolidation, SE API wrapper, findspam, spamhandling (to hopefully be less reliant on MS)

@quartata did you ever end up implementing the notifications?

@angussidney yeah, they're working

@angussidney findspam is the big one

Postdata has already been partially done by Thomas

9:11 PM

> Merging #1135 into master will increase coverage by 0.47%. The diff coverage is 74.53%.

we're in business

\o/

codecov is being a dork and saying it's still waiting for CI but it updated the comment so

So is my allspam fix the only thing we're waiting on?

[ SmokeDetector | MS ] Blacklisted website in body: My wordpress site shows the .htaccess content instead of output by cody cortez on askubuntu.com

Possibly diff coverage too, but Art said it can be merged with one of the two

9:13 PM

Diff coverage passed too

Yay

it's 10 points over the requirement

@angussidney no rush tho

fp by Zanna

I might also try some more real-life tests before we merge

@angussidney @quartata lemme know when you're ready for it to be merged

9:17 PM

ok so it looks like travis decided to rerun and that's why codecov is being a dork

that would have been me attempting to get codecov to look at the latest updates

which didn't work because it sucks

I have literally no idea what it thinks it's waiting for

it received the report from travis

When I pressed the "push notifications now"

it threw an error

literally just "sorry not found"

can we make our own coverage service or something

honest question

or maybe give coveralls a try

if you want

Codecov is open source, we can always take the coverage bit and add our own GH integration

@Andy would know about that I think

@angussidney the coverage bit is actually done by pytest

codecov's job is literally just to show the numbers

9:21 PM

But TBH I dont think it's worth it

@quartata well, OK

and it's sucking at that

@angussidney codecov have a GH integration now - they used to do it by bot comments, now it's an integration, which I've just installed

@ArtOfCode do you think that was the issue?

@ArtOfCode do we want to get a final review from everyone before we merge or will we just merge and get it running straight away?

why the checks aren't passing

9:22 PM

@quartata not a clue

@angussidney if the two of you think it's good to go, and both coverage scores are passing (which they are), then I'm happy with it

Cool

fp by Zanna on Creating custom legend to map to custom css torque heatmap [MS]

CI on 86edbee succeeded.

@quartata coveralls.io/github/Charcoal-SE/SmokeDetector

Thomas Ward

@Mithrandir haha. Very funny.

@ArtOfCode nice

Just drop the codecov after_success then and I'll merge it into mine

9:34 PM

done

CI on 08eb927 succeeded.

@ArtOfCode should probably change the badge and remove any webhooks too

fp by Zanna on Is there root for us cellular lg k8 us375 [MS]

Conflicting feedback across revisions: current, #1

Hrmm GH mobile doesn't have a way to compare forks it seems

@Zanna might want to review that ^^

Mithrandir

@ThomasWard ;)

Zanna

9:43 PM

@quartata hmm? What should I do?

I've just spent like 20 minutes editing that answer and every other post on the page...

(my rep on AE is meagre though, so I mean suggesting edits)

New metasmoke user 'Videonauth' created

Thomas Ward

9:58 PM

just kidding ;)

@Zanna I meant the conflicting feedback

The last time that was reported it was marked as a TP

10:25 PM

Restart: API quota is 8706.

[ SmokeDetector | MS ] Bad keyword in body: Creating Planes of Bubbles in Polymer Samples by Aaron Garcia on engineering.SE

Zanna

Yes, I mean I spent some time looking at it and it doesn't seem like spam to me

10:41 PM

New metasmoke user 'WELZ' created

[ SmokeDetector | MS ] Potentially bad keyword in answer: Adding slides to an existing carousel manually by Ian G. on wordpress.SE

[ SmokeDetector | MS ] Blacklisted website in body: My wordpress site shows the .htaccess content instead of output by cody cortez on askubuntu.com

WELZ

@SmokeDetector why

@WELZ Body - Position 489-499: menshealth

[ SmokeDetector | MS ] Link at end of body: Problems With Android-x86 7.1 on Virtualbox by Michelle Brand on askubuntu.com

paper1111

sd f

@SmokeDetector f

@SmokeDetector n